Repository navigation
fix: resolve CO_API_URL when clients are constructed - #819
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CO_API_URLis evaluated in constructor default arguments when the modules are imported. Setting it afterimport cohere(for example while loading application configuration) or changing it before constructing another client does not affect the default endpoint. All four public client classes exhibit this behavior.Change
Resolve
CO_API_URLat construction time in the handwritten V1 clients and let the V2 constructors delegate that resolution. Explicit non-None base URLs retain precedence, and removing the environment variable restores the normal production endpoint. The existing URL normalization remains in place.Only
.fernignore-protected client modules and a new test file change; generated endpoints and models are untouched. Imports in the changed modules were cleaned up to satisfy Ruff.Validation
All checks used the repository Poetry environment. Final 8 regressions were rerun after import cleanup.