Skip to content

feat(toolchain): add patch_strip attr for python_repository - #2201

Merged
rickeylev merged 6 commits into
bazel-contrib:mainfrom
aignas:feat/add-patch-strip
Sep 9, 2024
Merged

rickeylev merged 6 commits into
bazel-contrib:mainfrom
aignas:feat/add-patch-strip

Conversation

@aignas

@aignas aignas commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

This value has been hardcoded for a long time, so let's add the patch_strip
attribute to the WORKSPACE setups now so that we add less tech debt in the
bzlmod world later and need to migrate bzlmod users from the hard coded
value to something that can be configured.

This should be backwards compatible because of the default int value of 1
for the patch_strip attribute.

Summary:

  • feat: add patch_strip to python_repository.
  • feat: add the default value of patch_strip to get_release_info.
  • refactor: handle patch_strip key in TOOL_VERSIONS.

Work towards #2081.

@aignas
aignas requested a review from rickeylev as a code owner September 7, 2024 12:56
Comment thread python/private/python_repositories.bzl Resolved
@rickeylev
rickeylev enabled auto-merge September 8, 2024 23:49
@rickeylev
rickeylev added this pull request to the merge queue Sep 9, 2024
Merged via the queue into bazel-contrib:main with commit c804a13 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants