Skip to content

cleanup(tests): Use new APIs in rules_testing 0.4.0 - #1307

Merged
chrislovecnm merged 1 commit into
bazel-contrib:mainfrom
rickeylev:rules_testing.cleanup
Jul 11, 2023
Merged

chrislovecnm merged 1 commit into
bazel-contrib:mainfrom
rickeylev:rules_testing.cleanup

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator
  • Use public APIs for DictSubject and StrSubject.
  • Use rules_testing's StructSubject instead of our own.

Work towards 1297

* Use public APIs for DictSubject and StrSubject.
* Use rules_testing's StructSubject instead of our own.

Work towards 1297
@rickeylev
rickeylev requested a review from chrislovecnm July 11, 2023 16:54

@chrislovecnm chrislovecnm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrislovecnm
chrislovecnm enabled auto-merge July 11, 2023 17:15
@chrislovecnm
chrislovecnm added this pull request to the merge queue Jul 11, 2023
Merged via the queue into bazel-contrib:main with commit 02b521f Jul 11, 2023
@rickeylev
rickeylev deleted the rules_testing.cleanup branch July 11, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants