Migrate jackson 2.x to 3.x - #746
vmillet-dev wants to merge 2 commits into
Conversation
908eee2 to
529fda5
Compare
| implementation 'tools.jackson.core:jackson-core:3.0.4' | ||
| implementation 'tools.jackson.core:jackson-databind:3.0.4' |
There was a problem hiding this comment.
This version is affected by GHSA-72hv-8253-57qq consider using 3.1.0
There was a problem hiding this comment.
thx for reporting this, I updated to 3.1.0
|
We also would need this upgrade because wanna fix the security issue. Sadly we depend on io.ktor:ktor-server-auth-jwt which depends on this library. So they also could not remove dependency to jackson 2 yet. Would be great to see this one merged with latest jackson 3 version! |
c035590 to
bef6a41
Compare
bef6a41 to
0cb936b
Compare
|
May I know if there is a timeline or plan to do the release for jackson 3.x? |
|
Hi @vmillet-dev Thanks for putting this together, we appreciate the effort. We want to acknowledge the community demand here (and in #730 ). We understand this is a blocker for some, especially in dealing with transitive dependency conflicts and the security advisory on older Jackson 2.x versions. This migration carries significant implications, bumping the Java baseline to 17 and introducing a breaking change for consumers. We're currently evaluating the impact internally. We're looking at usage metrics and downstream effects to make sure we land on the right approach for the broadest set of users. We'll share the final plan once we've completed the evaluation. Thanks for your patience. |
|
This Upgrade is pending since March and we have constantly issues due to this dependency in our projects due to snyk issues from those deprecated dependencies. Would you please mind to finally raise jackson or merge the PRs after reviewing? I think patience is gone now. Thank you |
|
@tanya732 - just a friendly bump regarding this PR, any updates here? 😊 |
|
Hi @vmillet-dev Following up on our earlier comment now that we’ve completed our evaluation. Thanks again for putting this together and for all the work that went into the PR. We’ve also taken the feedback and concerns raised in #730 into account, particularly around transitive dependency conflicts and the security concerns with older Jackson 2.x versions. After evaluating the downstream impact, we’ve decided that java-jwt v5.0.0 will move forward with the Jackson 3 migration and a Java 17 baseline. Since Jackson is an internal implementation detail of java-jwt and is not exposed through the public API, we believe this keeps the scope of the major version change as focused as possible. The main compatibility consideration for consumers will therefore be the Java 17 requirement, along with any changes necessary as part of the Jackson 3 migration. We’ll use this PR as the basis for the migration and will follow up with a migration guide and timeline as we get closer to the release. Thanks again for driving this forward and for your patience while we worked through the impact. |
Disclaimer
Moving to jackson 3 (and implicitly java 17) are maybe a real breaking change, I don't know the policy of maintainers about older java versions compatibilities, but well, I did this work for myself in first place, so at least you can take a look
Changes
From jackson3 migration guide (link bellow):
References
Checklist