Skip to content

Fix three codebase bugs - #1

Draft
arjunmeda wants to merge 1 commit into
mainfrom
cursor/fix-three-codebase-bugs-7270
Draft

arjunmeda wants to merge 1 commit into
mainfrom
cursor/fix-three-codebase-bugs-7270

Conversation

@arjunmeda

Copy link
Copy Markdown
Owner

Address three bugs: improve Base64 encoding safety, fix HashableValue.equals contract, and harden driver download script robustness.

  • WritableStream: The previous Base64 encoding could lead to IndexOutOfBoundsException or incorrect data due to ByteBuffer.array() behavior.
  • Serialization.HashableValue: The equals method lacked proper type and null checks, violating the Object.equals contract and potentially causing ClassCastException or incorrect behavior in collections.
  • scripts/download_driver_for_all_platforms.sh: Unquoted variables and an incorrect trap command introduced security vulnerabilities (word splitting, globbing) and made the script less reliable.

Open in Cursor Open in Web

Co-authored-by: arjunmeda025 <arjunmeda025@gmail.com>
@cursor

cursor Bot commented Aug 23, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants