Skip to content

fix: bound Ticker callbacks and stop policy loading safely - #282

Merged
hsluoyz merged 1 commit into
masterfrom
review/cpp-1680-02-ticker-lifecycle-20261106
Nov 7, 2026
Merged

hsluoyz merged 1 commit into
masterfrom
review/cpp-1680-02-ticker-lifecycle-20261106

Conversation

@EmryZhang

Copy link
Copy Markdown
Contributor

Ticker creates and retains an asynchronous task on every tick. Slow callbacks accumulate, and stopping can wait behind the timer's interval lock.

Run callbacks on one worker, wake interval waits on stop, and join after releasing the timer state lock. Handle StopAutoLoadPolicy before auto-loading has started. Add regressions for slow callbacks, restart, interruption of a long wait and repeated stop before start.

Validation: the three lifecycle tests pass 25 iterations. A local integration build passes all 79 C++ tests.

@hsluoyz
hsluoyz merged commit adec06b into master Nov 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants