Repository navigation
fix(m3-tokens): wrong hue reference - #29902
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
simonkovtyk
marked this pull request as ready for review
November 21, 2024 12:26
simonkovtyk
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
November 21, 2024 12:26
andrewseguin
approved these changes
Dec 20, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there
Recently, I made some own implementations for my company to support multiple paletts for M3 and I orientated my code at the token generation here.
I found out, that Angular Material is sometimes not using the right tokens for some color roles as described in the offical Figma Template here.
Overview
For a better overview, I provided the differences here in a table.
Light mode
Dark mode
Thank you for your patience!