You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug(core-theming): get-theme-color($theme, $role-color) returns incorrect shades for 4 colors #29577
call get-theme-color($theme, role-color) for role colors 'surface', 'on-surface-variant', 'surface-container-highest'
compare shades of colors from the pallet that are returned. wrong shades are used according to spec
Expected Behavior
correct shades are returned based on the specification. reproduction steps are very clear.
Actual Behavior
slightly wrong color shades are returned than on specification. just compare whatever is here for given mode light/dark mode and you can clearly see that wrong shades are used
Environment
Angular: 18.1.0
CDK/Material: 18.1.0
Browser(s): all, browser independent
Operating System (e.g. Windows, macOS, Ubuntu): Mac and Windows
changed the title [-]bug(core-theming): get-theme-color($theme, $role-color) returns incorrect shades for 2 colors[/-][+]bug(core-theming): get-theme-color($theme, $role-color) returns incorrect shades for 4 colors[/+]on Aug 14, 2024
Activity
[-]bug(core-theming): get-theme-color($theme, $role-color) returns incorrect shades for 2 colors[/-][+]bug(core-theming): get-theme-color($theme, $role-color) returns incorrect shades for 4 colors[/+]amysorto commentedon Aug 27, 2024
Good catch, thanks for pointing this out!
As mentioned above, the current colors are mapped incorrectly. The rest should be audited as well:
surfacemaps to neutral 99 instead of neutral 98surfacemaps to neutral 10 instead of neutral 6on-surface-variantmaps to neutral 80 instead of 90surface-container-highestmaps to neutral 22 instead of 24angular-automatic-lock-bot commentedon Sep 29, 2024
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.