Adjusted permission check#2763
Conversation
Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here
|
The problem is AngularFire's API has always expected the developer to request permission manually, so in order to not break semver & take the peer we gated it. We can consider dropping this at the next major version, not before. |
Good to know. Looking forward to it. |
|
Hey there, we have a new major of AngularFire coming up, but we've changed directions and are shipping the same API as Firebase JS SDK. Thanks for the contribution but I'm going to close this as it's no longer relevant to the new design #2770. Looking forward to any ideas you might have to improve the library in the future! |
Since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here
Checklist
yarn install,yarn testrun successfully? yesDescription
As explained in the commit: since late 2019, getToken() has automatically requested permission, so no need to check if it is granted here.