Repository navigation
Conversation
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Thanks, I just signed the CLA. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Thanks. Looking forward to this as without it, Jasmine 2.0 tests dont work with Angular. PS - Karma no longer works either :( |
|
merged. thanks John! |
|
karma needs to be fixed separately. I see that there is a PR from @r-park waiting for @vojtajina's review. |
|
Agreed on karma. Separate issue too. Thanks for the Jasmine/ngMocks compat fix! |
Addresses #5632
#5632