Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor currentSpec to work for Jasmine 2 - #5662

Closed
johnpapa wants to merge 1 commit into
angular:masterfrom
johnpapa:master
Closed

johnpapa wants to merge 1 commit into
angular:masterfrom
johnpapa:master

Conversation

@johnpapa

@johnpapa johnpapa commented Jan 7, 2014

Copy link
Copy Markdown
Contributor

Addresses #5632

#5632

@IgorMinar

Copy link
Copy Markdown
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@johnpapa

johnpapa commented Jan 7, 2014

Copy link
Copy Markdown
Contributor Author

Thanks, I just signed the CLA.

@IgorMinar

Copy link
Copy Markdown
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@ghost ghost assigned tbosch Jan 8, 2014
@johnpapa

johnpapa commented Jan 8, 2014

Copy link
Copy Markdown
Contributor Author

Thanks. Looking forward to this as without it, Jasmine 2.0 tests dont work with Angular.

PS - Karma no longer works either :(

@IgorMinar

Copy link
Copy Markdown
Contributor

merged. thanks John!

@IgorMinar

Copy link
Copy Markdown
Contributor

karma needs to be fixed separately. I see that there is a PR from @r-park waiting for @vojtajina's review.

@johnpapa

Copy link
Copy Markdown
Contributor Author

Agreed on karma. Separate issue too.

Thanks for the Jasmine/ngMocks compat fix!

juliemr pushed a commit to juliemr/angular.js that referenced this pull request Jan 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants