fix(@schematics/angular): support spy call arguments migration in refactor-jasmine-vitest#33206
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new transformation function, transformAllCallsArgs, to the Jasmine-to-Vitest refactoring tool. This function handles the conversion of spy.calls.all()[i].args into the Vitest-compatible vi.mocked(spy).mock.calls[i] format, and a corresponding test case has been added. The review feedback suggests adding an explicit type check for allPae.expression to ensure it is a PropertyAccessExpression before passing it to getSpyIdentifierFromCalls, which improves type safety and maintains consistency with other transformation logic in the codebase.
…actor-jasmine-vitest The `refactor-jasmine-vitest` schematic fails to remove `.args` when migrating `spy.calls.all()[i].args`, resulting in uncompilable code in Vitest. Now, a specialized transformer detects `spy.calls.all()[i].args` and transforms it to `vi.mocked(spy).mock.calls[i]`, removing the unnecessary `.args` property access. Fixes angular#33112
hawkgs
approved these changes
May 15, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
refactor-jasmine-vitestschematic fails to remove.argswhen migratingspy.calls.all()[i].args, resulting in uncompilable code in Vitest.Now, a specialized transformer detects
spy.calls.all()[i].argsand transforms it tovi.mocked(spy).mock.calls[i], removing the unnecessary.argsproperty access.Fixes #33112