Skip to content

ng add @angular/ssr fails with TypeError when an NgModule in the app module file has no bootstrap array #34761

Open

Description

@0z5a

Command

add

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

I think before the server schematic started inferring the app component name (commit ea1143d, April 2025). I have not run an older release to confirm.

Description

ng add @angular/ssr (and ng generate server) crashes on an NgModule-based app when one of the @NgModule decorators in the file that main.ts bootstraps has no bootstrap array. The cases I hit:

  1. The root module uses ngDoBootstrap() instead of bootstrap: [...] (Angular Elements apps, AngularJS hybrid apps that bootstrap through UpgradeModule).
  2. The file declares another @NgModule without bootstrap (for example a small shared module) before the root module.

In packages/schematics/angular/utility/standalone/app_component.ts, resolveNgModuleBasedData loops over the module's @NgModule decorators and does:

const bootstrapProp = getMetadataField(node, 'bootstrap').find(...);
const componentIdentifier = (bootstrapProp?.initializer as ts.ArrayLiteralExpression)
  .elements[0] as ts.Identifier | undefined;

When bootstrapProp is undefined, the optional chain stops at initializer and .elements is read from undefined. The function is meant to return null in that case: the caller in server/index.ts already falls back to App / AppModule when nothing is found. So the schematic stops with a TypeError instead of using the fallback (case 1) or the right module (case 2).

Minimal Reproduction

  1. ng new demo --no-standalone
  2. In src/app/app-module.ts, remove bootstrap: [App] and add ngDoBootstrap() {} to AppModule.
  3. ng add @angular/ssr

Or, for case 2, keep bootstrap: [App] and put this above AppModule in the same file:

@NgModule({ exports: [] })
export class SharedModule {}

I reproduced this with SchematicTestRunner against @schematics/angular 22.3.0 (workspace -> application --standalone=false -> edit the module -> server and ssr schematics). Both schematics throw for case 1, and server throws for case 2. The unmodified app works.

Exception or Error

TypeError: Cannot read properties of undefined (reading 'elements')
    at resolveNgModuleBasedData (node_modules/@schematics/angular/utility/standalone/app_component.js:65:14)

Your Environment

@schematics/angular 22.3.0
@angular-devkit/schematics 22.3.0
Node.js 22.23.5

Anything else relevant?

Skipping decorators that have no bootstrap field (continue, like the ts.isObjectLiteralExpression check just above it) is enough to fix both cases: case 2 then finds AppModule, and case 1 falls through to the existing fallback. I have a patch with two tests in server/index_spec.ts and can open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions