TodoMVC Angular Bug Fixes

[flashdesignory]

this slipped through somehow, but the dynamic classes of the todo items wasn't applied correctly.
Additionally, I needed to override some css styles to ensure the custom component don't interfere with display.

@kara

[kara]

LGTM

[lpardosixtosMs]

LGTM

[lpardosixtosMs]

@flashdesignory Would you mind rebuilding the angular complex version too?
@issackjohn maybe we should add some scripts to keep the standalone versions and their complex counterparts in sync.

[flashdesignory]

@flashdesignory Would you mind rebuilding the angular complex version too? @issackjohn we should add some scripts to keep the standalone versions and their complex counterparts in sync.

I just have to run npm install on the big dom generator and npm run build in the complex version, correct?

[issackjohn]

@flashdesignory Would you mind rebuilding the angular complex version too? @issackjohn we should add some scripts to keep the standalone versions and their complex counterparts in sync.

I just have to run npm install on the big dom generator and npm run build in the complex version, correct?

I also run npm install in the complex directory. I'm adding these prerequisites to a build script in the complex version in a follow-up PR which was promised.

[flashdesignory]

@flashdesignory Would you mind rebuilding the angular complex version too? @issackjohn we should add some scripts to keep the standalone versions and their complex counterparts in sync.

I just have to run npm install on the big dom generator and npm run build in the complex version, correct?

I also run npm install in the complex directory. I'm adding these prerequisites to a build script in the complex version in a follow-up PR which was promised.

yup, did that as well. should be all in this pr now. Please let me know if I forgot anything.

[rniwa]

Do we have before/after numbers on browsers?

[flashdesignory]

Do we have before/after numbers on browsers?

The css bug fixes address user interaction, but don't change the test steps behavior.
We don't edit the todo items in the suites and test that behavior.

[flashdesignory]

chrome before:

chrome after:

safari before:

safari after:

firefox before:

firefox after:

[julienw]

Interestingly, :last-child can be costly, and this might explain why all browsers see a slight increase in their runtime. But I don't mind keeping it as it's very likely that this is used this way in real-world websites.

[julienw]

Sorry for the delay, this looks good to me.