Skip to content

newssite - potential fix for test - #180

Merged
flashdesignory merged 2 commits into
WebKit:mainfrom
flashdesignory:newssite-test-01
May 24, 2023
Merged

newssite - potential fix for test#180
flashdesignory merged 2 commits into
WebKit:mainfrom
flashdesignory:newssite-test-01

Conversation

@flashdesignory

Copy link
Copy Markdown
Contributor

this might fix this issue: #179

update:
simplified test and removed toast close action on the homepage.

@flashdesignory
flashdesignory requested a review from rniwa May 24, 2023 07:12
@rniwa

rniwa commented May 24, 2023

Copy link
Copy Markdown
Member

This doesn't fix the problem. As far as I can tell, this is some kind of a WebKit bug that somehow ends up loading speedometer's home page in the iframe.

@flashdesignory

Copy link
Copy Markdown
Contributor Author

This doesn't fix the problem. As far as I can tell, this is some kind of a WebKit bug that somehow ends up loading speedometer's home page in the iframe.

Ah, that's weird. So it's not that it can't find the element on the page of the newssite, it just loads something totally different?

I can't replicate it on my machine so it's hard to debug.
Is it on certain versions of safari? any steps to repro?
How does it actually look when running? do you get that error in the console?

@rniwa

rniwa commented May 24, 2023

Copy link
Copy Markdown
Member

This doesn't fix the problem. As far as I can tell, this is some kind of a WebKit bug that somehow ends up loading speedometer's home page in the iframe.

Ah, that's weird. So it's not that it can't find the element on the page of the newssite, it just loads something totally different?

Yeah, we're somehow loading Speedometer's home page after having ran previous steps. So somehow click() is triggering a navigation to home page but src stays in the news site so it's even more bizarre.

I can't replicate it on my machine so it's hard to debug. Is it on certain versions of safari? any steps to repro? How does it actually look when running? do you get that error in the console?

I can reproduce it on both Safari Technology Preview 169 as well as Safari 16.4. It's such a bizarre bug. Somehow we're replacing the contents of iframe with Speedometer's harness page in the middle of tests after having successfully ran previous steps.

@rniwa

rniwa commented May 24, 2023

Copy link
Copy Markdown
Member
Screenshot 2023-05-24 at 12 31 42 AM

@rniwa

rniwa commented May 24, 2023

Copy link
Copy Markdown
Member

Hm... removing failing steps won't be enough. We're now hitting this error instead at the end of TodoMVC-Angular:

[Error] SecurityError: Attempt to use history.replaceState() more than 100 times per 30 seconds
replaceState
i — vue-router.mjs:514
(anonymous function) — vue-router.mjs:483
A — vue-router.mjs:569
841 — index.js:5
d — bootstrap:19
(anonymous function) — chunk loaded:25
(anonymous function) — startup:5
Global Code — startup:5

@rniwa

rniwa commented May 24, 2023

Copy link
Copy Markdown
Member

Looks like commenting out the last 3 BenchmarkTestStep would do the trick.

@flashdesignory

Copy link
Copy Markdown
Contributor Author

Is the security error triggered by summing up the api calls from all workloads or per test?

@rniwa

rniwa commented May 24, 2023

Copy link
Copy Markdown
Member

Is the security error triggered by summing up the api calls from all workloads or per test?

Yeah, it seems like the issue is that across various tests, we end up exceeding 100 requests / 30s :(

@flashdesignory

Copy link
Copy Markdown
Contributor Author

pushed change - if you want to try it.

that security error will always be an issue the more workloads we add in that case.

@rniwa rniwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "fixes" the issue for me. I should debug Safari/WebKit though. This is such a bizarre bug!

@rniwa rniwa added the non-trivial change A change that affects benchmark results label May 24, 2023
@flashdesignory

Copy link
Copy Markdown
Contributor Author

This "fixes" the issue for me. I should debug Safari/WebKit though. This is such a bizarre bug!

awesome - i'll merge it in for now.

@flashdesignory
flashdesignory merged commit dbc7082 into WebKit:main May 24, 2023
@flashdesignory
flashdesignory deleted the newssite-test-01 branch May 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-trivial change A change that affects benchmark results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants