Skip to content

add a basic developer mode ui on the main runner - #166

Merged
bgrins merged 6 commits into
WebKit:mainfrom
bgrins:devmode-ui
May 20, 2023
Merged

add a basic developer mode ui on the main runner#166
bgrins merged 6 commits into
WebKit:mainfrom
bgrins:devmode-ui

Conversation

@bgrins

@bgrins bgrins commented May 19, 2023

Copy link
Copy Markdown
Contributor

@bgrins
bgrins requested review from flashdesignory and rniwa May 19, 2023 14:58
Comment thread resources/developer-mode.mjs Outdated
Comment thread resources/developer-mode.mjs Outdated
Comment thread resources/developer-mode.mjs Outdated
Comment thread resources/developer-mode.mjs Outdated
Comment thread resources/developer-mode.mjs Outdated
Comment thread resources/developer-mode.mjs Outdated
@rniwa rniwa added the non-trivial change A change that affects benchmark results label May 19, 2023

@flashdesignory flashdesignory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rniwa left some great comments, nothing additional from my side that's crucial.

super duper nit: the expanded view hurts my eyes... any way to make that a little more toned down?

@bgrins

bgrins commented May 19, 2023

Copy link
Copy Markdown
Contributor Author

super duper nit: the expanded view hurts my eyes... any way to make that a little more toned down?

No problem, I had just grabbed the background with the eyedropper from the logo, I'll tone it down.

@bgrins
bgrins merged commit d8e35c4 into WebKit:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-trivial change A change that affects benchmark results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test picker UI to the main runner if ?developerMode is set

3 participants