Skip to content

Gradle build update - #1136

Merged
PhilipRoman merged 5 commits into
TooTallNate:masterfrom
PhilipRoman:gradle-build-fix
Mar 30, 2021
Merged

Gradle build update#1136
PhilipRoman merged 5 commits into
TooTallNate:masterfrom
PhilipRoman:gradle-build-fix

Conversation

@PhilipRoman

Copy link
Copy Markdown
Collaborator

Description

Motivation and Context

Ensures that this project can be built using Gradle

How Has This Been Tested?

Built on jdk-8 and jdk-15, with Gradle 6.8.3. I manually verified that the maven-publish plugin works and produces the following POM file:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.java-websocket</groupId>
  <artifactId>Java-WebSocket</artifactId>
  <version>1.5.2-SNAPSHOT</version>
  <dependencies>
    <dependency>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-api</artifactId>
      <version>1.7.25</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PhilipRoman
PhilipRoman requested a review from marci4 March 29, 2021 08:18
@marci4 marci4 added the Build label Mar 29, 2021
@PhilipRoman
PhilipRoman merged commit 6e1d80f into TooTallNate:master Mar 30, 2021
@PhilipRoman
PhilipRoman deleted the gradle-build-fix branch March 30, 2021 06:33
@marci4 marci4 added this to the Release 1.5.2 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants