Skip to content

luhn.py: Favor list comprehensions over maps#4663

Merged
l3str4nge merged 2 commits into
masterfrom
cclauss-patch-4
Aug 27, 2021
Merged

luhn.py: Favor list comprehensions over maps#4663
l3str4nge merged 2 commits into
masterfrom
cclauss-patch-4

Conversation

@cclauss
Copy link
Copy Markdown
Member

@cclauss cclauss commented Aug 24, 2021 •
edited
Loading

As discussed in CONTRIBUTING.md.

@QuantumNovice your review, please.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 24, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 27, 2021
@l3str4nge l3str4nge merged commit 46e56fa into master Aug 27, 2021
@cclauss cclauss deleted the cclauss-patch-4 branch August 27, 2021 09:52
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
luhn.py: Favor list comprehensions over maps (TheAlgorithms#4663)
0202859 
* luhn.py: Favor list comprehensions over maps

As discussed in CONTRIBUTING.md.

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @l3str4nge