Skip to content

basic_maths input check#4486

Merged
l3str4nge merged 3 commits into
TheAlgorithms:masterfrom
haningrisha:prime_factors_input_check
Jun 16, 2021
Merged

basic_maths input check#4486
l3str4nge merged 3 commits into
TheAlgorithms:masterfrom
haningrisha:prime_factors_input_check

Conversation

@haningrisha
Copy link
Copy Markdown
Contributor

@haningrisha haningrisha commented Jun 5, 2021

Describe your change:

  • Function prime_factors, number_of_divisors, sum_of_divisors has to have input check, because 0 input causes infinite loop

  • Doctest initialization on script start

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@haningrisha haningrisha requested a review from Kush1101 as a code owner June 5, 2021 18:00
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jun 5, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 16, 2021
@l3str4nge l3str4nge merged commit 4f9ee43 into TheAlgorithms:master Jun 16, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@haningrisha @shermanhui
basic_maths input check (TheAlgorithms#4486)
6824429 
* Prime factor input check

* number_of_divisors input check

* sum_of_divisors input check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@onlinejudge95 onlinejudge95 onlinejudge95 approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haningrisha @l3str4nge @onlinejudge95