Skip to content

Add new algorithm for Armstrong numbers#4474

Merged
cclauss merged 2 commits into
TheAlgorithms:masterfrom
AndersonTorres:new-armstrong
Jun 4, 2021
Merged

Add new algorithm for Armstrong numbers#4474
cclauss merged 2 commits into
TheAlgorithms:masterfrom
AndersonTorres:new-armstrong

Conversation

@AndersonTorres
Copy link
Copy Markdown
Contributor

@AndersonTorres AndersonTorres commented Jun 2, 2021 •
edited
Loading

Add a new algorithm for verify if a number is an Armstrong.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@AndersonTorres AndersonTorres requested a review from Kush1101 as a code owner June 2, 2021 14:21
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jun 2, 2021
cclauss
cclauss reviewed Jun 2, 2021
View reviewed changes
Comment thread maths/armstrong_numbers.py Outdated
cclauss
cclauss reviewed Jun 2, 2021
View reviewed changes
Comment thread maths/armstrong_numbers.py Outdated
Prajwalprakash3722
Prajwalprakash3722 suggested changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown

@Prajwalprakash3722 Prajwalprakash3722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented the required changes

Comment thread maths/armstrong_numbers.py
cclauss
cclauss requested changes Jun 3, 2021
View reviewed changes
Comment thread maths/armstrong_numbers.py Outdated
Comment thread maths/armstrong_numbers.py
@ghost ghost added awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Jun 3, 2021
cclauss
cclauss reviewed Jun 3, 2021
View reviewed changes
Comment thread maths/armstrong_numbers.py Outdated
cclauss
cclauss reviewed Jun 3, 2021
View reviewed changes
Comment thread maths/armstrong_numbers.py Outdated
cclauss
cclauss reviewed Jun 3, 2021
View reviewed changes
Comment thread maths/armstrong_numbers.py
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jun 3, 2021
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jun 3, 2021

Please run psf/black on the file as discussed in CONTRIBUTING.md or the tests will not pass.

@AndersonTorres AndersonTorres requested a review from cclauss June 3, 2021 22:29
@ghost ghost removed the tests are failing Do not merge until tests pass label Jun 4, 2021
cclauss
cclauss approved these changes Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 4, 2021
@cclauss cclauss merged commit f37d415 into TheAlgorithms:master Jun 4, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@AndersonTorres @cclauss @shermanhui
Add new algorithm for Armstrong numbers (TheAlgorithms#4474)
7fc7ad1 
* Add a new algorithm for Armstrong numbers

* FAILING = (-153, -1, 0, 1.2, 200, "A", [], {}, None)

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

+2 more reviewers

@haningrisha haningrisha haningrisha left review comments

@Prajwalprakash3722 Prajwalprakash3722 Prajwalprakash3722 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndersonTorres @cclauss @haningrisha @Prajwalprakash3722