CNN classification added to computer vision

[9harshit]

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[dhruvmanila]

Good job so far!

Another doubt: does this fall under computer vision or should be in the machine learning, I don't know much about it so you can guide me on this one :)

You should either turn on pre-commit (instruction in CONTRIBUTING.md) or look at the logs and fix the errors (mostly it would be related to formatting). Running black should be done as well.

[9harshit]

Good job so far!

Another doubt: does this fall under computer vision or should be in the machine learning, I don't know much about it so you can guide me on this one :)

You should either turn on pre-commit (instruction in CONTRIBUTING.md) or look at the logs and fix the errors (mostly it would be related to formatting). Running black should be done as well.

1. Computer Vision comes under Machine learning but since the repo had a dedicated section for CV I added the code in Computer Vision who's description states : "While computer vision comes from modelling image processing using the techniques of machine learning, computer vision applies machine learning to recognize patterns for interpretation of images"

2. I already ran pre-commit, black ,flake8 before pushing the file as asked earlier

[9harshit]

Hi, is there still issue with my code ? my code hasn't been merged

[dhruvmanila]

Sorry for taking so long and thank you for your patience! This looks like it's ready to be merged except for just one nitpick :)

Also, there's no need to create a directory for one file, you can put the file on it's own in computer_vision/cnn_classification.py

[dhruvmanila]

LGTM! 🎉

Thank you for your contribution and welcome to the community!

[cclauss]

The new version of Tensorflow seems to be causing these tests to fail.