Skip to content

Update LinkedQueue#3683

Merged
cclauss merged 2 commits into
TheAlgorithms:masterfrom
realDuYuanChao:LinkedQueue
Oct 24, 2020
Merged

Update LinkedQueue#3683
cclauss merged 2 commits into
TheAlgorithms:masterfrom
realDuYuanChao:LinkedQueue

Conversation

@realDuYuanChao
Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost
Copy link
Copy Markdown

ghost commented Oct 24, 2020

This PR is not a good idea, reason:

  • type hinting removal
  • not required name changes

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 24, 2020

Type hints should not be removed.

The method naming should match Python's builtin queue:
https://docs.python.org/3/library/queue.html#queue.Queue.put

@realDuYuanChao
Copy link
Copy Markdown
Member Author

@cclauss I did. Please review again.

@ghost
Copy link
Copy Markdown

ghost commented Oct 24, 2020

The method naming should match Python's builtin queue:
https://docs.python.org/3/library/queue.html#queue.Queue.put

cclause said this, please check your PR. It basically will do nothing beneficial after all.

A possible thing you can do is a add a new algorithm. Keep it up 😄

Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@cclauss cclauss merged commit 1cd8e68 into TheAlgorithms:master Oct 24, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* update LinkedQueue

* add type hint and rename
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* update LinkedQueue

* add type hint and rename
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* update LinkedQueue

* add type hint and rename
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* update LinkedQueue

* add type hint and rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants