Add Emacs regression tests for PSES - #1820
Merged
Merged
Conversation
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/emacs-test
branch
from
June 9, 2022 18:01
986b1e5 to
a3c3dc3
Compare
Andy Jordan (andyleejordan)
marked this pull request as ready for review
June 9, 2022 18:10
Member
Author
|
Should prevent #1695 from recurring. |
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
June 9, 2022 19:18
This adds regression tests written in Emacs to validate that PSES can be connected (and reports diagnostics) with a client that isn't VS Code, namely [Eglot](https://github.com/joaotavora/eglot).
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/emacs-test
branch
from
June 9, 2022 22:42
a3c3dc3 to
69e4793
Compare
Patrick Meinecke (SeeminglyScience)
approved these changes
Jun 10, 2022
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
Amazing, LGTM!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds regression tests written in Emacs to validate that PSES can be connected (and reports diagnostics) with a client that isn't VS Code, namely Eglot, and Emacs LSP client.