Fix startup bug when zero profiles are present - #1807
Merged
Conversation
The service would fail to fully start if zero profiles were present, because that meant we attempted to invoke an empty command, which then threw `PSInvalidOperationException: No commands are specified`. This wasn't caught by our task executor, since it happened in a delegate which directly invoked the command.
| // false` to avoid an exception here. Instead, we must just not execute it. | ||
| if (psCommand.Commands.Count > 0) | ||
| { | ||
| pwsh.InvokeCommand(psCommand); |
Member
Author
There was a problem hiding this comment.
TODO: Patrick Meinecke (@SeeminglyScience) we should check everywhere else we directly invoke too.
Patrick Meinecke (SeeminglyScience)
approved these changes
May 19, 2022
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service would fail to fully start if zero profiles were present, because that meant we attempted to invoke an empty command, which then threw
PSInvalidOperationException: No commands are specified. This wasn't caught by our task executor, since it happened in a delegate which directly invoked the command.