Fix prompt spam and general debugger reliability improvements - #1762
Merged
Andy Jordan (andyleejordan) merged 2 commits intoApr 19, 2022
Merged
Conversation
We definitely do not want to ignore cancel requests when the runspace **is** usable. Oops
This should make default prompt spam significantly less likely or impossible. Also fixes a scenario where if the REPL loop is evaluating and in an attached process, closing the attachee would dead lock.
Patrick Meinecke (SeeminglyScience)
requested a review
from Andy Jordan (andyleejordan)
as a code owner
April 19, 2022 18:42
Closed
6 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make default prompt spam significantly less likely or impossible. Also fixes a scenario here if the REPL loop is evaluating and in an attached process, closing the attachee would dead lock.
Also fixed a logic bug that probably caused some not yet seen issues.