Remove 'oldPowershellExeName' contains powershell.exe - #5408
Merged
Conversation
Chunqing Chen (chunqingchen)
requested review from
Bruce Payette (BrucePay),
Dongbo Wang (daxian-dbw) and
Jason Shirk (lzybkr)
as code owners
November 10, 2017 10:42
Chunqing Chen (chunqingchen)
force-pushed
the
bugfix_1
branch
from
November 13, 2017 10:55
46cb666 to
4fc55d1
Compare
Jason Shirk (lzybkr)
removed their request for review
November 16, 2017 00:31
Contributor
Author
|
Dongbo Wang (@daxian-dbw) hi dongbo, could you please take a look? |
Dongbo Wang (daxian-dbw)
previously requested changes
Nov 30, 2017
There was a problem hiding this comment.
old deps file should be removed.
There was a problem hiding this comment.
old deps file.
Dongbo Wang (daxian-dbw)
force-pushed
the
bugfix_1
branch
from
December 6, 2017 20:38
4fc55d1 to
ffd9368
Compare
Dongbo Wang (daxian-dbw)
dismissed
their stale review
December 6, 2017 20:40
New commit has been pushed to address the comment.
Dongbo Wang (daxian-dbw)
approved these changes
Dec 6, 2017
Dongbo Wang (daxian-dbw)
requested review from
Aditya Patwardhan (adityapatwardhan)
and removed request for
Bruce Payette (BrucePay)
December 6, 2017 20:41
Member
|
Aditya Patwardhan (@adityapatwardhan) Can you please take a look at this PR? Thanks! |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dec 6, 2017
Travis Plunk (TravisEz13)
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 7, 2017
Travis Plunk (TravisEz13)
pushed a commit
that referenced
this pull request
Dec 7, 2017
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #5135