put command discovery before scripts for Unix - #5116
Conversation
| $env:PATH = $originalPath | ||
| } | ||
|
|
||
| It "Should return a type of 'string' for hostname cmdlet" { |
There was a problem hiding this comment.
Now we skip the test - why?
There was a problem hiding this comment.
This test was created a long time ago. I think it's actually not useful and is implicitly covered by tests that follow. I'll remove it.
Ilya (iSazonov)
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
|
Andrew (@anmenaga) I was thinking that would be a good way for command discovery to find the "native command" and the powershell script to validate the command was executed over the script without polluting the current working directory. |
|
Mike Richmond (@mirichmo) can you merge? |
|
Is this change only for Unix? The title seems so but the change is not guarded by |
|
Dongbo Wang (@daxian-dbw) The code is guarded by a runtime Platform check. |
* put command discovery before scripts for Unix * remove unnecessary test
Also cleaned up the NativeLinuxCommands.Tests.ps1 script on skipping tests
Fix #2095