Skip to content

SetServiceCommand: Add positional parameter attribute - #5017

Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
travisty-:feature/service-command-parameters
Oct 9, 2017
Merged

SetServiceCommand: Add positional parameter attribute#5017
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
travisty-:feature/service-command-parameters

Conversation

@travisty-

@travisty- Travis Kinney (travisty-) commented Oct 5, 2017

Copy link
Copy Markdown
Contributor

Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.

Closes #4916.

@travisty-
SetServiceCommand: Add positional parameter attribute
6e76ad8 
Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 5, 2017 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 6, 2017

Copy link
Copy Markdown
Member

Travis Kinney (@travisty-) Please add tests for the new scenario at: https://github.com/PowerShell/PowerShell/blob/master/test/powershell/Modules/Microsoft.PowerShell.Management/Set-Service.Tests.ps1

@travisty-

Travis Kinney (travisty-) commented Oct 7, 2017

Copy link
Copy Markdown
Contributor Author

Hi Aditya Patwardhan (@adityapatwardhan) Dongbo Wang (@daxian-dbw), tests have been added for this scenario.

@iSazonov

Ilya (iSazonov) commented Oct 7, 2017

Copy link
Copy Markdown
Collaborator

Travis Kinney (@travisty-) Thanks for your contribution!

We should split formatting changes and code changes - this makes it easier to review and support code.
Please remove last commit and push only new test. We welcome improvements in formatting in a separate PR or commit.

Also if new test is under "Feature" CI tag please add [Feature] in header of your last commit to run the test in CI.

@travisty-
Add test for positional InputObjects [Feature]
04773a9 
Added a test to Set-Service validating InputObjects passed positionally.
@travisty-

Travis Kinney (travisty-) commented Oct 7, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback Ilya (@iSazonov). I'll submit the formatting improvements in a separate PR.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 1d5c310 into PowerShell:master Oct 9, 2017
@travisty-
Travis Kinney (travisty-) deleted the feature/service-command-parameters branch October 9, 2017 17:02
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@travisty- @adityapatwardhan
SetServiceCommand: Add positional parameter attribute (PowerShell#5017)
e0a3d11 
* SetServiceCommand: Add positional parameter attribute

Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.

* Add test for positional InputObjects [Feature]

Added a test to Set-Service validating InputObjects passed positionally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travisty- @msftclas @adityapatwardhan @iSazonov