Skip to content

Fix ConvertTo-Html single matched column header bug - #4276

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
mirichmo:pr-completion-for-convertto-html
Jul 18, 2017
Merged

Fix ConvertTo-Html single matched column header bug#4276
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
mirichmo:pr-completion-for-convertto-html

Conversation

@mirichmo

@mirichmo Mike Richmond (mirichmo) commented Jul 17, 2017

Copy link
Copy Markdown
Member

This replaces abandoned PR #2184 since the fix looks like it might be worthwhile to include. This PR adds the changes requested in the original PR that held it up from being merged.

PR #2241 included the original tests.

FYI: Tim Curwick (@TimCurwick)

@JamesWTruher

Copy link
Copy Markdown
Collaborator

LGTM

@mirichmo
Mike Richmond (mirichmo) force-pushed the pr-completion-for-convertto-html branch from 4cc8346 to 943eabd Compare July 18, 2017 20:27
@mirichmo

Copy link
Copy Markdown
Member Author

The content is the same. I just re-did the commit giving Tim Curwick (@TimCurwick) credit for it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirichmo

Copy link
Copy Markdown
Member Author

@PowerShell/powershell-maintainers This is ready for merge

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 4f13bf4 into PowerShell:master Jul 18, 2017
@mirichmo
Mike Richmond (mirichmo) deleted the pr-completion-for-convertto-html branch August 8, 2017 23:11
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants