Get-Help does not work in JEA sessions by chunqingchen · Pull Request #2988 · PowerShell/PowerShell

Chunqing Chen (chunqingchen) · 2017-01-10T06:00:49Z

Repro:

New-PSSessionConfigurationFile -Path .\basicRRS.pssc -SessionType RestrictedRemoteServer -RunAsVirtualAccount
Register-PSSessionConfiguration -Name 'JEARepro' -Path .\basicRRS.pssc
Enter-PSSession . -ConfigurationName JEARepro
Get-Help Select-Object

Expected behavior:
Help content is returned for the "Select-Object" cmdlet

Actual behavior:

Cannot find path '' because it does not exist.
    + CategoryInfo          : ObjectNotFound: (:) [Get-Help], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetHelpCommand

Chunqing Chen (chunqingchen) · 2017-01-11T18:21:59Z

Paul Higinbotham (@PaulHigin) :)

Paul Higinbotham (PaulHigin) · 2017-01-11T18:59:58Z

Can you please respond to me comment above?

Steve Lee (SteveL-MSFT) · 2017-01-25T00:10:04Z

Please add a test

Mike Richmond (mirichmo) · 2017-02-17T00:18:08Z

Chunqing Chen (@chunqingchen) Please update this PR with tests per Steve Lee (@SteveL-MSFT) 's request

Dongbo Wang (daxian-dbw) · 2017-02-17T22:39:03Z

Chunqing Chen (@chunqingchen) Please use a meaningful title and description for the PR. The current title and description is suitable for an issue but not for a PR.
The guidelines are kept in CONTRIBUTING.md and I quote here:

Add a meaningful title of the PR describing what change you want to check in. Don't simply put: "Fixes issue #5". A better example is: "Add Ensure parameter to New-Item cmdlet", with "Fixes #5" in the PR's body.
When you create a pull request, including a summary of what's included in your changes

Ilya (iSazonov) · 2017-03-15T05:24:09Z

Please use $helpContent | Should Not Be $null

Ilya (iSazonov) · 2017-03-15T05:24:49Z

Please add new line.

Ilya (iSazonov) · 2017-03-15T05:26:17Z

Please make the title more informative for the test.
Sample - "Get-Help in JEA sessions".

the test suite contains different bug fixes for JEA sessions. The information is contained in each test itself. thank you.

I believe that we should not mention "bug fixes" in the title and it is better to make comments in It blocks with a link to the bug number below.

# Fix #1234567890

Ilya (iSazonov) · 2017-03-15T05:27:50Z

Please use correct case and replace -force with -Force.

Chunqing Chen (chunqingchen) · 2017-03-15T21:51:05Z

Ilya (@iSazonov) your comment has been resolved. thank you

Paul Higinbotham (PaulHigin) · 2017-01-10T16:57:15Z

What is the user experience with this change? With this change does help still appear for cmdlets that are available in the JEA session? Please always include a description of the change along rationale for the change and any modification in experience.

With this change we now no longer throw a PathNotFound exception. How does this affect non-JEA sessions when the path cannot be resolved? Is it Ok to suppress the exception in this case?

Paul Higinbotham (PaulHigin) · 2017-03-15T21:59:10Z

Strange but my previous comment no longer appears. Anyway my concern with this change is that previously an exception was thrown if the resolvedProviderPath is null, but now it continues. This feels like a breaking change since it now can return incomplete help for non-JEA sessions. I am not sure if that is a big deal but maybe it would be possible to detect JEA session before skipping the error.

Ilya (iSazonov) · 2017-03-18T10:18:38Z

Test LGTM.

Paul Higinbotham (PaulHigin) · 2017-03-20T17:55:03Z

LGTM

Chunqing Chen (chunqingchen) · 2017-03-21T17:55:40Z

Dongbo Wang (@daxian-dbw) Hi, dongbo, can you help to merge? :)

Dongbo Wang (daxian-dbw) · 2017-03-21T18:03:52Z

Chunqing Chen (@chunqingchen) It looks new commits were pushed after the sign-off from Ilya (@iSazonov) and Paul Higinbotham (@PaulHigin). Please work with Mike Richmond (@mirichmo) to see if further review is needed.

Chunqing Chen (chunqingchen) · 2017-03-21T18:13:23Z

Mike Richmond (@mirichmo) Paul Higinbotham (@PaulHigin) The additional change I made is set the test case as pending because our current test harness is not supporting Register-PSSessionConfiguration cmdlet and needs further work around. however it won't blocking the product fix. Paul, would you please confirm if you are good with this?

Mike Richmond (mirichmo) · 2017-03-22T16:52:59Z

Paul Higinbotham (@PaulHigin) Please take a look and provide an updated sign off since there were updates since the original sign off.

Paul Higinbotham (PaulHigin) · 2017-03-22T17:21:57Z

I just checked and it turns out that ExecutionContext.InitialSessionState property can be null. Please add a check for this.

Paul Higinbotham (PaulHigin)

Please add check for _executionContext.InitialSessionState == null

Chunqing Chen (chunqingchen) · 2017-03-23T00:00:40Z

Paul Higinbotham (@PaulHigin) the comment has been resolved

Paul Higinbotham (PaulHigin)

LGTM

Mike Richmond (mirichmo) · 2017-03-23T16:06:17Z

Chunqing Chen (@chunqingchen) This PR has been approved, but has merge conflicts. Please resolve them and push an update. I'll merge after that.

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jan 10, 2017

Chunqing Chen (chunqingchen) requested a review from Paul Higinbotham (PaulHigin) January 10, 2017 06:01

PowerShellTeam added the Review - Needed The PR is being reviewed label Jan 10, 2017

Mike Richmond (mirichmo) added Review - Waiting on Author and removed Review - Needed The PR is being reviewed labels Feb 17, 2017

Jason Shirk (lzybkr) assigned Mike Richmond (mirichmo) Feb 23, 2017

Ilya (iSazonov) reviewed Mar 15, 2017

View reviewed changes

Paul Higinbotham (PaulHigin) reviewed Mar 15, 2017

View reviewed changes

Mike Richmond (mirichmo) added Review - Needed The PR is being reviewed and removed Review - Waiting on Author labels Mar 22, 2017

Paul Higinbotham (PaulHigin) reviewed Mar 22, 2017

View reviewed changes

Paul Higinbotham (PaulHigin) suggested changes Mar 22, 2017

View reviewed changes

Chunqing Chen (chunqingchen) added 2 commits March 22, 2017 16:58

Get-Help does not work in JEA sessions

5962d7d

Merge branch 'master' into bugfix2

4d38b48

Paul Higinbotham (PaulHigin) approved these changes Mar 23, 2017

View reviewed changes

Mike Richmond (mirichmo) merged commit 1393f45 into PowerShell:master Mar 23, 2017

Ilya (iSazonov) removed the Review - Needed The PR is being reviewed label Mar 27, 2017

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Get-Help does not work in JEA sessions (PowerShell#2988)

0d3f85f

Uh oh!

Conversation

Chunqing Chen (chunqingchen) commented Jan 10, 2017 • edited by joeyaiello Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Chunqing Chen (chunqingchen) commented Jan 11, 2017

Uh oh!

Paul Higinbotham (PaulHigin) commented Jan 11, 2017

Uh oh!

Steve Lee (SteveL-MSFT) commented Jan 25, 2017

Uh oh!

Mike Richmond (mirichmo) commented Feb 17, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Feb 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Mar 15, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Mar 18, 2017

Uh oh!

Paul Higinbotham (PaulHigin) commented Mar 20, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Mar 21, 2017

Uh oh!

Dongbo Wang (daxian-dbw) commented Mar 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Chunqing Chen (chunqingchen) commented Mar 21, 2017

Uh oh!

Mike Richmond (mirichmo) commented Mar 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Mar 23, 2017

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Mike Richmond (mirichmo) commented Mar 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Chunqing Chen (chunqingchen) commented Jan 10, 2017 •

edited by joeyaiello

Loading

Dongbo Wang (daxian-dbw) commented Mar 21, 2017 •

edited

Loading