Skip to content

Add CMAKE_CURRENT_BINARY_DIR to include path for generated header. - #73

Merged
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:masterfrom
cireu:fix-gen-h
Sep 3, 2021
Merged

Add CMAKE_CURRENT_BINARY_DIR to include path for generated header.#73
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:masterfrom
cireu:fix-gen-h

Conversation

@cireu

Copy link
Copy Markdown
Contributor

when I try build it out of source tree, compilers complains that cannot found pal_config.h

citreu@asus-laptop:~/tmp/psl-native-build$ LANG=C make
Consolidate compiler generated dependencies of target psl-native
[  1%] Building CXX object src/CMakeFiles/psl-native.dir/getppid.cpp.o
/home/citreu/gitrepos/PowerShell-Native/src/libpsl-native/src/getppid.cpp:4:10: fatal error: pal_config.h: No such file or directory
    4 | #include "pal_config.h"
      |          ^~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/CMakeFiles/psl-native.dir/build.make:160: src/CMakeFiles/psl-native.dir/getppid.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:169: src/CMakeFiles/psl-native.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
citreu@asus-laptop:~/tmp/psl-native-build$ pwd
/home/citreu/tmp/psl-native-build

Adding CMAKE_CURRENT_BINARY_DIR to header include path should fix this issue.

@andyleejordan

Copy link
Copy Markdown
Member

You are right!

@andyleejordan
Andy Jordan (andyleejordan) merged commit 8593a14 into PowerShell:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants