Build for Alpine arm64 and arm32 - #72
Open
Aditya Patwardhan (adityapatwardhan) wants to merge 13 commits into
Open
Build for Alpine arm64 and arm32#72Aditya Patwardhan (adityapatwardhan) wants to merge 13 commits into
Aditya Patwardhan (adityapatwardhan) wants to merge 13 commits into
Conversation
Aditya Patwardhan (adityapatwardhan)
requested a review
from Andy Jordan (andyleejordan)
August 30, 2021 19:53
Andy Jordan (andyleejordan)
approved these changes
Aug 30, 2021
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
Looks good to me 👍
Andy Jordan (andyleejordan)
requested changes
Sep 2, 2021
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
Fixed some stuff 🤞
Co-authored-by: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Andy Jordan (andyleejordan)
approved these changes
Sep 7, 2021
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
LGTM but do you want to squash and/or rebase the commits?
Member
Author
|
Typically we squash.. I am testing that these bits actually work. Also seems the CI does not upload artifacts.. I will work on that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.