Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable - #256
Merged
Travis Plunk (TravisEz13) merged 10 commits intoAug 8, 2019
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
requested a review
from Travis Plunk (TravisEz13)
August 1, 2019 23:21
Aditya Patwardhan (adityapatwardhan)
requested a review
from Andrew (anmenaga)
as a code owner
August 1, 2019 23:21
Reece Dunham (RDIL)
approved these changes
Aug 2, 2019
Aditya Patwardhan (adityapatwardhan)
force-pushed
the
AddDistChannel
branch
from
August 5, 2019 17:41
b116f19 to
0369e5e
Compare
Travis Plunk (TravisEz13)
requested changes
Aug 5, 2019
| ARG PS_PACKAGE_URL=https://github.com/PowerShell/PowerShell/releases/download/v${PS_VERSION}/${PS_PACKAGE} | ||
|
|
||
| ARG fromTag=7 | ||
| ARG imageRepo=centos |
There was a problem hiding this comment.
imageRepo is unused
Aditya Patwardhan (adityapatwardhan)
force-pushed
the
AddDistChannel
branch
from
August 8, 2019 20:36
0b85385 to
93e72fc
Compare
Member
Author
|
Travis Plunk (@TravisEz13) can you update your review? |
Travis Plunk (TravisEz13)
approved these changes
Aug 8, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable to all images.
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.