Skip to content

generalize the test case for sync rng for all supported models. - #3

Open
sayakpaul wants to merge 1 commit into
JingyaHuang:sync-parallel-rng-seedfrom
huggingface:generalize-parallel-rng-sync-tests
Open

sayakpaul wants to merge 1 commit into
JingyaHuang:sync-parallel-rng-seedfrom
huggingface:generalize-parallel-rng-sync-tests

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Nov 10, 2026 •

Copy link
Copy Markdown

WDYT?

Could you also run on Neuron and TPU to make sure I didn't break anything?

Comment thread tests/testing_utils.py


def require_torch_multi_accelerator(test_case=None, *, include_neuron: bool = False, include_tpu: bool = False):
def require_torch_multi_accelerator(test_case):

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the PR moves the RNG testing to specific Neuron and TPU test suites, they're no longer needed. But please double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant