This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Fix simple key usage.#5
Merged
stephenfrank merged 1 commit intoJun 24, 2015
Merged
Conversation
abc08ec to
86b172d
Compare
86b172d to
706ded0
Compare
Contributor
Author
|
Done. |
stephenfrank
added a commit
that referenced
this pull request
Jun 24, 2015
Fix simple key usage (expressions are not required to start with "."). Allow expressions to start with "0". Move expression sanitizing to lexer.
Contributor
|
Thanks, these all look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining the $ or . as a prefix is optional. This works in the original implementation.
Also, fixed usage of empty() where $group could be the string "0", and some other minor cleanups like moving all expression sanitizing to the lexer.