Skip to content

Do not attempt to read JavaThread state from non-JavaThread threads #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 1 commit into from
May 31, 2024
Merged

Do not attempt to read JavaThread state from non-JavaThread threads #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ddprof-lib/src/main/cpp/wallClock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ void WallClock::signalHandler(int signo, siginfo_t* siginfo, void* ucontext, u64

ExecutionEvent event;
VMThread* vm_thread = VMThread::current();
int raw_thread_state = vm_thread ? vm_thread->state() : 0;
bool is_java_thread = vm_thread && VM::jni();
int raw_thread_state = vm_thread && is_java_thread ? vm_thread->state() : 0;
bool is_initialized = raw_thread_state >= 4 && raw_thread_state < 12;
ThreadState state = ThreadState::UNKNOWN;
ExecutionMode mode = ExecutionMode::UNKNOWN;
Expand All @@ -82,7 +83,7 @@ void WallClock::signalHandler(int signo, siginfo_t* siginfo, void* ucontext, u64
if (os_state != ThreadState::UNKNOWN) {
state = os_state;
}
mode = VM::jni() != NULL ? convertJvmExecutionState(raw_thread_state) : ExecutionMode::JVM;
mode = is_java_thread ? convertJvmExecutionState(raw_thread_state) : ExecutionMode::JVM;
}
if (state == ThreadState::UNKNOWN) {
if (inSyscall(ucontext)) {
Expand Down