Skip to content

Fix Flaky annotation for JUnit5 forked tests - #12261

Open
sarahchen6 wants to merge 5 commits into
masterfrom
sarahchen6/fix-forked-flaky
Open

Fix Flaky annotation for JUnit5 forked tests#12261
sarahchen6 wants to merge 5 commits into
masterfrom
sarahchen6/fix-forked-flaky

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Fix @Flaky annotation that is not working on JUnit 5 forked tests by triggering useJUnitPlatform() for forked tests before the @Flaky annotation is assessed here: https://github.com/DataDog/dd-trace-java/blob/master/buildSrc/src/main/kotlin/dd-trace-java.configure-tests.gradle.kts#L107

Motivation

@Flaky-annotated forked tests should only run flaky test jobs

Additional Notes

I tested this fix with a flaky-annotated failing test in dd-trace-core/src/test/java/datadog/trace/core/scopemanager/IterationSpansForkedTest.java.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-official

datadog-official Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 58.65% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 462514f | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.78 s 14.73 s [-0.5%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 13.60 s 13.71 s [-1.4%; -0.1%] (maybe better)
startup:petclinic:appsec:Agent 16.86 s 16.82 s [-0.6%; +1.1%] (no difference)
startup:petclinic:iast:Agent 16.85 s 16.93 s [-1.3%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.56 s 16.75 s [-2.3%; +0.0%] (no difference)
startup:petclinic:sca:Agent 16.71 s 16.51 s [+0.5%; +1.9%] (maybe worse)
startup:petclinic:tracing:Agent 16.00 s 16.34 s [-3.1%; -1.1%] (significantly better)

Commit: 462514fd · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6 sarahchen6 changed the title Always useJUnitPlatform for JUnit 5 flaky test management Fix Flaky annotation for JUnit5 forked tests Aug 21, 2026
@sarahchen6
sarahchen6 force-pushed the sarahchen6/fix-forked-flaky branch from 0b43e2b to d264320 Compare August 21, 2026 20:51
@sarahchen6
sarahchen6 force-pushed the sarahchen6/fix-forked-flaky branch from d264320 to 462514f Compare August 21, 2026 22:02
@sarahchen6
sarahchen6 changed the base branch from jpbempel/g2j-core-pt13 to master August 21, 2026 22:03
@sarahchen6
sarahchen6 marked this pull request as ready for review August 21, 2026 22:05
@sarahchen6
sarahchen6 requested a review from a team as a code owner August 21, 2026 22:05
@sarahchen6
sarahchen6 requested review from PerfectSlayer and removed request for a team August 21, 2026 22:05
@dd-octo-sts

dd-octo-sts Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@sarahchen6 sarahchen6 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant