Migrate dd-trace-core groovy files to java part 13 by jpbempel · Pull Request #12253 · DataDog/dd-trace-java

jpbempel · 2026-08-21T09:21:07Z

What Does This Do

we migrate 17 tests:

ConflatingMetricAggregatorTest
FootprintForkedTest
MetricsAggregatorFactoryTest
MetricsReliabilityTest
OkHttpSinkTest
SerializingMetricWriterTest
AllSamplerTest
AsmStandaloneSamplerTest
DeterministicSpanSamplerTest
DeterministicTraceSamplerTest
ForcePrioritySamplerTest
RateByServiceTraceSamplerTest
RuleBasedSamplingTest
SamplerTest
SingleSpanSamplerTest
SpanSamplingRulesTest
TraceSamplingRulesTest

Motivation

this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
part4: #11146
part5: #11217
part6: #11362
part7: #11374
part8: #11437
part9: #11488
part10: #11543
part11: #11566
part12: #11619

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

we migrate 17 tests: - ConflatingMetricAggregatorTest - FootprintForkedTest - MetricsAggregatorFactoryTest - MetricsReliabilityTest - OkHttpSinkTest - SerializingMetricWriterTest - AllSamplerTest - AsmStandaloneSamplerTest - DeterministicSpanSamplerTest - DeterministicTraceSamplerTest - ForcePrioritySamplerTest - RateByServiceTraceSamplerTest - RuleBasedSamplingTest - SamplerTest - SingleSpanSamplerTest - SpanSamplingRulesTest - TraceSamplingRulesTest

dd-octo-sts · 2026-08-21T09:21:19Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37bcdd17fc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-21T09:34:22Z

+
+    // writer should be reset if reporting fails
+    assertTrue(latchTriggered);
+    verify(writer, atLeastOnce()).startBucket(anyInt(), anyLong(), anyLong());


Preserve the exact serialization-failure call count

If the reporting loop invokes startBucket more than once after this serialization error, atLeastOnce() still passes, whereas the migrated Spock interaction required exactly one invocation. This weakens the test so repeated failing writes or retries can regress unnoticed; retain the original cardinality with times(1).

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-21T09:34:22Z

+        Collections.singletonList(
+            new SimpleSpan("", "", "", "", false, false, false, 0, 0, HTTP_OK)));
+
+    clearInvocations(sink);


Clear sink invocations before publishing

With the 1 ms reporting interval, the scheduled reporter can process this trace after publish but before clearInvocations; the clear then erases the unexpected sink call, and the subsequent forced report is empty, so verifyNoInteractions passes even if an unmeasured trace was incorrectly reported. Move the clear before publish, as the following test already does.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-21T09:34:22Z

+    long after = footprint(aggregator, features);
+    assertTrue(after - baseline <= 10L * 1024 * 1024, "footprint growth exceeds 10MB");
+
+    aggregator.close();


Close the footprint aggregator on assertion failures

When the acknowledged-flaky footprint assertion or either preceding timeout fails, execution never reaches this close, whereas the original Spock cleanup block always ran. Because start() launches an aggregator thread and scheduled reporter and this table has six invocations in the same test JVM, the leaked instance can continue running and interfere with later footprint cases; put the lifecycle in a try/finally.

Useful? React with 👍 / 👎.

dd-octo-sts · 2026-08-21T09:46:04Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.81 s	14.71 s	[-0.1%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent	13.61 s	13.69 s	[-1.5%; +0.3%] (no difference)
startup:petclinic:appsec:Agent	16.89 s	16.57 s	[+1.0%; +2.7%] (significantly worse)
startup:petclinic:iast:Agent	16.89 s	16.96 s	[-1.2%; +0.3%] (no difference)
startup:petclinic:profiling:Agent	16.77 s	16.38 s	[-2.0%; +6.8%] (no difference)
startup:petclinic:sca:Agent	16.74 s	16.59 s	[-0.0%; +1.8%] (no difference)
startup:petclinic:tracing:Agent	15.69 s	15.11 s	[-4.5%; +12.2%] (unstable)

Commit: 6d857f0b · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

datadog-datadog-us1-prod

The Java migration weakens one exact call-count check. A repeated startBucket call now passes in the serialization-error test, but the old Groovy test rejects it.

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit 37bcdd1 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

datadog-datadog-us1-prod · 2026-08-21T09:49:01Z

+
+    // writer should be reset if reporting fails
+    assertTrue(latchTriggered);
+    verify(writer, atLeastOnce()).startBucket(anyInt(), anyLong(), anyLong());


Keep the exact startBucket call count

A later retry defect can reach production because this test no longer rejects repeated failed bucket starts.

Assertion details

Input: The periodic reporter calls startBucket more than once after a serialization failure.

Expected: The test must require exactly one startBucket call, as the original Groovy test does.

Actual: The migrated test uses atLeastOnce(). It passes when startBucket runs two or more times.

Suggested change

verify(writer, atLeastOnce()).startBucket(anyInt(), anyLong(), anyLong());

verify(writer, times(1)).startBucket(anyInt(), anyLong(), anyLong());

Was this helpful? React 👍 or 👎
_{🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

jpbempel requested a review from a team as a code owner August 21, 2026 09:21

jpbempel requested review from jandro996 and removed request for a team August 21, 2026 09:21

jpbempel added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Aug 21, 2026

This comment has been minimized.

Sign in to view

chatgpt-codex-connector Bot reviewed Aug 21, 2026

View reviewed changes

datadog-datadog-us1-prod Bot reviewed Aug 21, 2026

View reviewed changes

jpbempel added 2 commits August 21, 2026 15:55

address codex comments

d0990c3

fix FootprintForkedTest

6d857f0

Navigation Menu

Uh oh!

Migrate dd-trace-core groovy files to java part 13 - #12253

Migrate dd-trace-core groovy files to java part 13#12253
jpbempel wants to merge 3 commits into
masterfrom
jpbempel/g2j-core-pt13

jpbempel commented Aug 21, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Aug 21, 2026

Uh oh!

This comment has been minimized.

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Uh oh!

jpbempel Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Uh oh!

jpbempel Aug 21, 2026

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Uh oh!

jpbempel Aug 21, 2026

Uh oh!

dd-octo-sts Bot commented Aug 21, 2026 •

edited

Loading

Uh oh!

datadog-datadog-us1-prod Bot left a comment

Uh oh!

datadog-datadog-us1-prod Bot Aug 21, 2026

Uh oh!

jpbempel Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	verify(writer, atLeastOnce()).startBucket(anyInt(), anyLong(), anyLong());
	verify(writer, times(1)).startBucket(anyInt(), anyLong(), anyLong());

Uh oh!

Conversation

jpbempel commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

dd-octo-sts Bot commented Aug 21, 2026

Uh oh!

This comment has been minimized.

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

jpbempel Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

jpbempel Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

jpbempel Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

datadog-datadog-us1-prod Bot left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-us1-prod Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

jpbempel Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jpbempel commented Aug 21, 2026 •

edited

Loading

dd-octo-sts Bot commented Aug 21, 2026 •

edited

Loading