Skip to content

[module-webdriver] fix type error in PHP 8.1 when converting ms to sec#103

Merged
Naktibalda merged 2 commits into
Codeception:2.0from
macghriogair:bugfix/php8.1-type-error-formatLogEntries
Jul 27, 2022
Merged

[module-webdriver] fix type error in PHP 8.1 when converting ms to sec#103
Naktibalda merged 2 commits into
Codeception:2.0from
macghriogair:bugfix/php8.1-type-error-formatLogEntries

Conversation

@macghriogair

@macghriogair macghriogair commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

fixes 102

php -v
PHP 8.1.8 (cli) (built: Jul 11 2022 08:53:35) (NTS)
---
TypeError date(): Argument #2 ($timestamp) must be of type ?int, float given
TypeError Uncaught \TypeError

TypeError at /xxx/vendor/codeception/module-webdriver/src/Codeception/Module/WebDriver.php:721

Fixes a type error when calling date function with a float while formatting log entries:

@macghriogair macghriogair mentioned this pull request Jul 25, 2022
Closed
@Naktibalda Naktibalda merged commit e0aa26c into Codeception:2.0 Jul 27, 2022
Naktibalda pushed a commit that referenced this pull request Jul 27, 2022
@macghriogair @Naktibalda
[module-webdriver] fix type error in PHP 8.1 when converting ms to sec (
1c2680b 
#103)

* [module-webdriver] fix type error in PHP 8.1 when converting milliseconds to seconds

* simplify using intval

Co-authored-by: Patrick Mac Gregor <patrick.macgregor@foo.ag>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macghriogair @Naktibalda