[Codecept5] Improved support for Codeception 5/PHP 8#154
Conversation
There was a problem hiding this comment.
I normalised composer.json using ergebnis/composer-normalize. I like the consistency of a normalised composer.json but happy to revert if you'd prefer it to be kept as-is.
|
@yesdevnull The next thing to do is to update lib-innerbrower to be compatible with the changes from This module doesn't support Symfony 6 yet... although i already added the corresponding branch in the test project https://github.com/codeception/symfony-module-tests/tree/6.0 . Which leads me to say that we don't need smoke tests as we do have tests for this. Please check the aforementioned codeception-module-tests, maybe it should be mentioned in the I'm a big fan of all the initiatives to 'normalize', 'update' and 'standardize', so I support you on the topic of normalizing the Lastly, regarding PHPStan, yes please! |
711e45a to
deb389c
Compare
| "codeception/lib-innerbrowser": "^2.0 | *@dev", | ||
| "codeception/codeception": "dev-5.0-interfaces as 5.0.x-dev" | ||
| "codeception/codeception": "dev-5.0-interfaces as 5.0.0", | ||
| "codeception/lib-innerbrowser": "dev-master" |
There was a problem hiding this comment.
dev-5.0-interfaces branch is gone, you can set codeception/codeception to ^5.0.0-alpha2 and lib-innerbrowser to ^3.0.
I need to do the following:
Consolidate Symfony version requirements compared to Codeception 5 (e.g. supported PHP versions).
Symfony 4.4 and 5.4 are LTS versions so are updated to support the latest PHP versions.
Fix
codeception/codeceptionversion requirement.Fix
codeception/lib-innerbrowserversion requirement.Add several basic smoke tests?
Correct commit message to be consistent with repository.
Bonus points (for a separate PR maybe):
module-doctrine2)