Skip to content

[Codecept5] Improved support for Codeception 5/PHP 8#154

Closed
yesdevnull wants to merge 3 commits into
Codeception:3.0from
yesdevnull:codecept5
Closed

[Codecept5] Improved support for Codeception 5/PHP 8#154
yesdevnull wants to merge 3 commits into
Codeception:3.0from
yesdevnull:codecept5

Conversation

@yesdevnull

@yesdevnull yesdevnull commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

I need to do the following:

  • Consolidate Symfony version requirements compared to Codeception 5 (e.g. supported PHP versions).
    Symfony 4.4 and 5.4 are LTS versions so are updated to support the latest PHP versions.

  • Fix codeception/codeception version requirement.

  • Fix codeception/lib-innerbrowser version requirement.

  • Add several basic smoke tests?

  • Correct commit message to be consistent with repository.

Bonus points (for a separate PR maybe):

@yesdevnull yesdevnull changed the title [Codecept5] Support for Codeception 5 [Codecept5] Improved support for Codeception 5/PHP 8 Feb 9, 2022

@yesdevnull yesdevnull left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normalised composer.json using ergebnis/composer-normalize. I like the consistency of a normalised composer.json but happy to revert if you'd prefer it to be kept as-is.

@TavoNiievez TavoNiievez changed the base branch from main to 3.0 February 9, 2022 13:09
@TavoNiievez TavoNiievez self-assigned this Feb 9, 2022
@TavoNiievez

Copy link
Copy Markdown
Member

@yesdevnull The next thing to do is to update lib-innerbrower to be compatible with the changes from Codeception/dev-5.0-interfaces.

This module doesn't support Symfony 6 yet... although i already added the corresponding branch in the test project https://github.com/codeception/symfony-module-tests/tree/6.0 .

Which leads me to say that we don't need smoke tests as we do have tests for this. Please check the aforementioned codeception-module-tests, maybe it should be mentioned in the README.md that we have the tests in another repository.
It can help you understand how it works by reading the main.yml file and maybe CONTRIBUTING.md

I'm a big fan of all the initiatives to 'normalize', 'update' and 'standardize', so I support you on the topic of normalizing the composer.json file.
The only thing is that since this is normalization, it would only make sense if all of Codeception uses the same normalized style. So I would ask you to raise PR to update that in all of our repositories if you want to go ahead.

Lastly, regarding PHPStan, yes please!
A separate PR would be nice.

Comment thread composer.json Outdated
Comment thread readme.md
Comment thread composer.json
"codeception/lib-innerbrowser": "^2.0 | *@dev",
"codeception/codeception": "dev-5.0-interfaces as 5.0.x-dev"
"codeception/codeception": "dev-5.0-interfaces as 5.0.0",
"codeception/lib-innerbrowser": "dev-master"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-5.0-interfaces branch is gone, you can set codeception/codeception to ^5.0.0-alpha2 and lib-innerbrowser to ^3.0.

@Naktibalda Naktibalda deleted the branch Codeception:3.0 March 16, 2022 08:52
@Naktibalda Naktibalda closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants