Skip to content

Improved support for Codeception 5/PHP 8 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TavoNiievez merged 3 commits into from
Feb 11, 2022
Merged

Improved support for Codeception 5/PHP 8 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
618934f
Improved support for Codeception 5/PHP 8
yesdevnull Feb 9, 2022
ed2513c
Removed redundant line in .gitattributes file
yesdevnull Feb 11, 2022
ea916d9
Add conflict for pre-5.0 Codeception installations
yesdevnull Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
/tests export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/Robofile.php export-ignore
/*.md export-ignore
/*.yml export-ignore
18 changes: 12 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,34 @@
{
"name": "codeception/module-datafactory",
"description": "DataFactory module for Codeception",
"keywords": [ "codeception" ],
"homepage": "https://codeception.com/",
"type": "library",
"license": "MIT",
"type": "library",
"keywords": [
"codeception"
],
"authors": [
{
"name": "Michael Bodnarchuk"
}
],
"minimum-stability": "dev",
"homepage": "https://codeception.com/",
"require": {
"php": "^8.0",
"codeception/codeception": "dev-5.0-interfaces as 5.0.x-dev",
"codeception/codeception": "dev-5.0-interfaces as 5.0.0",
"league/factory-muffin": "^3.3",
"league/factory-muffin-faker": "^2.3"
},
"conflict": {
"codeception/codeception": "<5.0"
},
"minimum-stability": "dev",
"autoload": {
"classmap": [
"src/"
]
},
"config": {
"classmap-authoritative": true
"classmap-authoritative": true,
"sort-packages": true
}
}
14 changes: 11 additions & 3 deletions src/Codeception/Module/DataFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,18 @@ class DataFactory extends Module implements DependsOnModule, RequiresPackage

public ?FactoryMuffin $factoryMuffin = null;

protected array $config = ['factories' => null, 'customStore' => null];
/**
* @var array<string, mixed>
*/
protected array $config = [
'factories' => null,
'customStore' => null,
];

public function _requires(): array
{
return [
FactoryMuffin::class => '"league/factory-muffin": "^3.0"',
FactoryMuffin::class => '"league/factory-muffin": "^3.3"',
];
}

Expand Down Expand Up @@ -243,7 +249,9 @@ public function _after(TestInterface $test)

public function _depends(): array
{
return [ORM::class => $this->dependencyMessage];
return [
ORM::class => $this->dependencyMessage,
];
}

/**
Expand Down