This repository was archived by the owner on Apr 21, 2026. It is now read-only.
Update v6 release - #5
Merged
Merged
Conversation
* Improve Readme.md for not so advanced users 1. Add brief description about the 3 possible ways of executing queries: passing the query to a pool, borrowing a client from a pool or obtaining an exclusive client. Give examples for the 3 of them. 2. Use the examples to teach how to reuse a pool in all of your project. This should be helpful for not so advanced users and prevents mistakes. 3. Open a troubleshooting section. * Shrink Troubleshooting and Point to Examples 1. Troubleshooting/FAQ section will only contain a reference to the wiki FAQ. I've already moved the content to the wiki. 2. At the end of "Pooling example" point to the wiki example page. Also indicate that there they can find how to use node-postgres with promises and async/await. I've already created that content in the wiki.
Make pg-native able to pass sslmode, sslca, sslkey and sslcert params to libpq
* Support for logical streaming replication * Wrong compare expr in getLibpqConnectionString * Simplify codes for replication parameter
* Fix escaping of libpq connection string properties Fix handlings of libpq connection properties to properly escape single quotes and backslashes. Previously the values were surrounded in single quotes which handled whitespace within the property value, but internal single quotes and backslashes would cause invalid connection strings to be generated. * Update expected output in test to be quoted Update the expect host output in the connection parameter test to expect it to be surrounded by single quotes. * Add test for configs with quotes and backslashes
* Going red: using a config object creates two pools when missing some params It should only create a pool in a consistent way, even if some params are not provided in the first place. * Delay the pool name generation to make it consistent between calls * Don't fallback to empty object as config is already defined
* Remove redundant tests
* Add client connectionString test
Add test to ensure { connectionString } is respected as an argument to the client constructor
* Add test for connection string property
Also fixed some legacy require statements.
This adds deprecations in preparation for `pg@7.0` - deprecate using event emitters on automatically created results from client.query. - deprecate query.promise() - it should never have been a public method and it's not documented. I need to do better about using _ prefix on private methods in the future. - deprecate singleton pool on the `pg` object. `pg.connect`, `pg.end`, and `pg.cancel`.
* WIP * Remove console.log messages
Bump version
PostgreSQL 10 reports its version as only `major.minor`, so it can’t be parsed with semver. The `server_version_num` setting is a major version followed by a four-digit minor version since version 10, and was a three-digit major version followed by a two-digit minor version before that.
Algunenano
force-pushed
the
cdb-6.1_update
branch
12 times, most recently
from
May 23, 2018 17:26
6e316ab to
1416a31
Compare
Algunenano
force-pushed
the
cdb-6.1_update
branch
from
May 23, 2018 17:34
1416a31 to
5e70051
Compare
dgaubert
approved these changes
May 24, 2018
dgaubert
left a comment
There was a problem hiding this comment.
Lots of changes 😅 most of them cherry-picked.
Looks good to me. Let's integrate with node-cartodb-psql and friends before release a new tag.
enekid
approved these changes
May 24, 2018
| node_js: "6" | ||
| addons: | ||
| postgresql: "9.6" | ||
| env: |
There was a problem hiding this comment.
Didn't know that travis could handle these environment combinations:
- PG 9.5 - node6
- PG 9.5 - node8
- PG 10 - node6
- PG 10 - node8
Great!
Author
There was a problem hiding this comment.
If it weren't because PG10 is not fully integrated the script could be simpler (no manual install). For example:
postgresql:
- "9.5"
- "9.6"
node_js:
- "6"
- "8"
Will create a matrix of 4 configurations automatically with those packages setup properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to CartoDB/node-cartodb-psql#30 I'm going to make a release here and point node-cartodb-psql to this branch+release.