Skip to content

fix: Update the nodejs buildpack in the manifest file - #27

Merged
krook merged 1 commit into
Call-for-Code:mainfrom
Akash-Nayak:fix-nodejs-buildpack-bug
Oct 28, 2021
Merged

fix: Update the nodejs buildpack in the manifest file#27
krook merged 1 commit into
Call-for-Code:mainfrom
Akash-Nayak:fix-nodejs-buildpack-bug

Conversation

@Akash-Nayak

@Akash-Nayak Akash-Nayak commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Fixes - #26

After updating the manifest file I was able to successfully run ibmcloud cf push --no-start.

weather-api-nodejs git:(main) ✗ ibmcloud cf push --no-start
Invoking 'cf push --no-start'...

Using manifest file /Users/akash/github/weather-api-nodejs/manifest.yml
Deprecation warning: Use of 'buildpack' attribute in manifest is deprecated in favor of 'buildpacks'. Please see https://docs.cloudfoundry.org/devguide/deploy-apps/manifest-attributes.html#deprecated for alternatives and other app manifest deprecations. This feature will be removed in the future.

Getting app info...
Creating app with these attributes...
+ name:                weather-api-nodejs
  path:                /Users/akash/github/weather-api-nodejs
  buildpacks:
+   https://github.com/cloudfoundry/nodejs-buildpack
+ command:             npm start
+ health check type:   process
+ instances:           1
+ memory:              256M
  env:
+   NPM_CONFIG_PRODUCTION
+   WEATHER_API_KEY

Creating app weather-api-nodejs...
Comparing local files to remote cache...
Packaging files to upload...
Uploading files...
 1.92 MiB / 1.92 MiB [================================] 100.00% 3s

Waiting for API to complete processing files...

name:              weather-api-nodejs
requested state:   stopped
routes:            
last uploaded:     
stack:             
buildpacks:        

type:            web
instances:       0/1
memory usage:    256M
start command:   npm start
     state   since                  cpu    memory   disk     details
#0   down    2021-10-28T13:34:10Z   0.0%   0 of 0   0 of 0 

Signed-off-by: Akash Nayak akash19nayak@gmail.com

Signed-off-by: Akash Nayak <akash19nayak@gmail.com>
@Akash-Nayak

Copy link
Copy Markdown
Contributor Author

Can someone please review the PR? @krook @vabarbosa @ptitzler
Thanks in advance!

@krook

krook commented Oct 28, 2021

Copy link
Copy Markdown
Member

Thanks for the contribution @Akash-Nayak! Looks good to me.

@krook
krook merged commit cf23ce6 into Call-for-Code:main Oct 28, 2021
@Akash-Nayak

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution @Akash-Nayak! Looks good to me.

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants