Skip to content

D-VAS R14: act drops two allocations per call (no measurable time gain) - #2071

Merged
AdaWorldAPI merged 2 commits into
mainfrom
claude/d-vas-r14-act-allocs
Nov 13, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
claude/d-vas-r14-act-allocs

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Follow-up to R13 (#2070). Behaviour unchanged.

Change (mailbox-lanes/src/act.rs)

  • The gate plane is handed to Planes as a borrowed slice instead of a one-element vector.
  • The row bits are built only for an Intent, which owns them; a method that writes nothing no longer copies the gate.

Measured (release, 40 rows, median of 9 batches, one machine)

read-only path allocations before after ns before ns after
act, whole source 45 43 3698.6 3801.6
act_over, distinct 47 45 3882.9 3571.7
act_over, bag 48 46 3687.8 3824.0

The times are within this example's run-to-run spread (up to 1.5x), so no time gain is claimed. Bytes per call fell by 24.

Why so little

The premise that act's own vectors matter was wrong, and the R13 table already showed it: the stages allocate 37 of the 45 (DT64 admission and lane binding, the guard's lowering, R2IL prepare and run); act itself only 8. This lever is spent. Reducing the rest means changing those crates or keeping their results between calls.

Test

tests/population.rs::a_read_only_act_allocates_what_was_measured pins the count on the four-row fixture at 41 with a thread-local counting allocator. It was committed first and failed at 43.

Checks

51 tests in the crate, clippy --all-targets -D warnings, fmt --check, codegraph --check, supersession index regenerated (unchanged).

Do not merge automatically.


Generated by Claude Code

…oday, fails)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
…for an intent (45 -> 43 allocations)

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 59b59b5e-d8f4-41d3-b0aa-f27dca92d878
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review November 13, 2026 18:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T18:54:05.871129Z 1a574a5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 3c626af into main Nov 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants