Repository navigation
D-VAS R14: act drops two allocations per call (no measurable time gain) - #2071
Merged
Merged
Conversation
…oday, fails) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
…for an intent (45 -> 43 allocations) Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
AdaWorldAPI
marked this pull request as ready for review
November 13, 2026 18:53
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to R13 (#2070). Behaviour unchanged.
Change (
mailbox-lanes/src/act.rs)Planesas a borrowed slice instead of a one-element vector.Intent, which owns them; a method that writes nothing no longer copies the gate.Measured (release, 40 rows, median of 9 batches, one machine)
act, whole sourceact_over, distinctact_over, bagThe times are within this example's run-to-run spread (up to 1.5x), so no time gain is claimed. Bytes per call fell by 24.
Why so little
The premise that
act's own vectors matter was wrong, and the R13 table already showed it: the stages allocate 37 of the 45 (DT64 admission and lane binding, the guard's lowering, R2IL prepare and run);actitself only 8. This lever is spent. Reducing the rest means changing those crates or keeping their results between calls.Test
tests/population.rs::a_read_only_act_allocates_what_was_measuredpins the count on the four-row fixture at 41 with a thread-local counting allocator. It was committed first and failed at 43.Checks
51 tests in the crate,
clippy --all-targets -D warnings,fmt --check, codegraph--check, supersession index regenerated (unchanged).Do not merge automatically.
Generated by Claude Code