Skip to content

D-VAS R2: mailbox selections (A3), versioned coordinate over MapTable (B2); B1 blocked - #2062

Merged
AdaWorldAPI merged 8 commits into
claude/d-vas-r1-e0from
claude/d-vas-r2-selection
Nov 13, 2026
Merged

AdaWorldAPI merged 8 commits into
claude/d-vas-r1-e0from
claude/d-vas-r2-selection

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #2061 (which is stacked on #2060). D-VAS-A3, D-VAS-B2; D-VAS-B1 is BLOCKED with its source finding. Ledger: .claude/plans/d-vas-implementation-v1.md, section R2. Draft; not for merge without a merge decision. A4 (typed selection folds) is not started.

Head eec7280cc. Crate lance-graph-mailbox-lanes: 12 tests, debug and release, 0 failed; clippy -D warnings clean.

A3: the socket issues its own selections

MailboxLanes implements DT64's SelectionSource. It issues position lists itself, from the published columns:

  • issue_order(column): the populated rows sorted by a column, ties in row order
  • issue_where(column, Keep): a filter by one unsigned column comparison, in row order
  • issue_concat(a, b): one issued selection followed by another, the only way a bag with repeats arises

A caller cannot hand in positions. The lists are views of one publication: they live in the socket and end with the borrow. The mailbox itself has no home for an order and none was added. The 65,537th name is refused, never aliased. dr256_ternlog_lab::OrderIndex / SealedOrder are not reused: lab crate, i32 keys only.

tests/selection.rs, 3 tests on a real MailboxSoA<64> (48 rows). Oracle: a sort of (value, row) pairs, a filter and per-row occurrence counts over owner.meta. Six disable runs, all exit 101: sort removed; < as <=; concatenation deduplicating; the frame check removed; the name wrapping; the row-order/scope check removed.

B2: one id, unchanged bytes, two coordinate versions

coords::Coordinates pairs one tile of DT64's existing MapTable at one sealed version with a lane binding. No table, id storage or version counter is added. The source version (the publication) and the coordinate version (the map) are separate: advancing the map writes nothing to the mailbox and leaves the lane binding valid.

tests/coords.rs, 2 tests: 48 ids read through assignment 1, the map advances, the same ids read through assignment 2 with the source bytes equal before and after; the first binding is then StaleMapping for all 48 ids while its assignment stays readable as history. Refused: an unmapped id, a row number offered as an id, another table's frame, an unknown tile, a row past the lane, a repeated id. Three disable runs, all exit 101: the currency check removed; the row bound removed; the current frame taken at read time.

Limit: the id is the map's own u64, not a NodeGuid, and the test fills the map. No authority fills it for a mailbox.

B1: NodeGuid to a row is BLOCKED

  • The declared seam is MailboxSoaView::row_for_local_key(u64). Its doc names the authority: an owner that stores keys, "the in-RAM MailboxSoA, once it carries a local_key column". MailboxSoA has no such column and does not override the default None.
  • Closing it on the owner is a new column of MailboxSoA<N>: a layout change, excluded here without a separate decision.
  • The argument is NodeGuid::local_key(), the V1 family ++ identity tail; it discriminates only after the 10-byte prefix is resolved.
  • MapTable keys a u64 inside a u32 tile, and no authority maps a GUID prefix to a tile.

Nothing was built in its place.

Not established

A selection or coordinate binding that outlives its publication (see #2061); filters beyond one unsigned comparison; typed folds over u32/u64 lanes; cost.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk

…concat); tests before the run

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 68872869-a74f-4447-a083-6baf42ff6d47

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review November 13, 2026 11:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T11:22:44.974817Z a8e73ac Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8e73ac813

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@AdaWorldAPI AdaWorldAPI changed the title D-VAS R2 (part 1): the mailbox socket issues its own selections (A3) D-VAS R2: mailbox selections (A3), versioned coordinate over MapTable (B2); B1 blocked Nov 13, 2026
…t (review finding), before the fix

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
… the socket's own space

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
…and u64 lanes; before the run

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
…ls named

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMMWgnUU9g7Ldyn6sbk
@AdaWorldAPI
AdaWorldAPI merged commit 46ea721 into claude/d-vas-r1-e0 Nov 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants