Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gitcollect/InjectModuleInitializer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: kzu/InjectModuleInitializer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 19 files changed
  • 2 contributors

Commits on Mar 5, 2017

  1. Improving compatibility with VS2017 and .NETCore projects

    The existing package has a number of problems:
    - Usage of powershell for adding content files: these files
      are no longer executed by nuget (IIRC, as of NuGet v3+)
    - Since they are no longer run, not only does the sample .cs
      does not get injected, but neither does the target run at
      all since it's also the PS1 that did the injection of an
      MSBuild target.
    
    The latter is unnecessary since NuGet already supports providing
    targets via nugets. This is added by providing the new InjectModuleInitializer.targets
    as part of the nuget package.
    
    WRT to the sample content file, since it adds little value and
    it will be tricky to maintain in a compatible way across content vs
    contentFiles and packages.config vs project.json/PackageReference in
    VS2015+, I think it's simply better to just improve the readme.txt.
    
    After all, it's just a simple class with one method. No big deal copying
    it from the readme after installing.
    kzu committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    718f3bc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Migrate to SDK style and SDK pack

    Remove all the cruft from the old-way, including:
    
    - Make the csproj nicer by using SDK-style
    - Use PackageReference for Mono.Cecil instead of checking in libs
    - Remove the manually crafted .nuspec and and folder structure and
      let NuGet (SDK) Pack do its work instead
    - Include a .props that allows third parties to invoke the tool by
      using $(InjectModuleInitializerTool)
    - Update the .targets to make it incremental build friendly, and
      support strong named assemblies too
    - Temporarily remove tests from project (this needs to go into
      another project, now that there is a free test runner that can
      be installed in Community (TestDriven.NET).
    - Remove the embedded assembly hack for loading Cecil, since this
      is a standalone tool that can simply resolve its own assemblies
      from its local directory under \tools
    - Account for minor changes in Cecil that require disposing the
      assembly and reading it in memory up-front.
    - Bump version to 2.0.0 since there's quite significant changes,
      including not supporting the old .ps1 anymore.
    kzu committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    7383a0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    888c2c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Merge pull request kzu#12 from kzu/master

    Improving compatibility with VS2017 and .NETCore projects
    kzu authored Aug 17, 2018
    Configuration menu
    Copy the full SHA
    e3c5337 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a46c7a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Configuration menu
    Copy the full SHA
    eb4edaf View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Fix incorrect argument order

    ensch authored and kzu committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    7491a23 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. Only add signing if SignAssembly==true, in addition of having a key

    Since the compiler won't sign the main assembly in that case either.
    kzu authored May 27, 2019
    Configuration menu
    Copy the full SHA
    e08ca86 View commit details
    Browse the repository at this point in the history
Loading