This repository was archived by the owner on May 14, 2026. It is now read-only.
fix: Fix check so it's all lowercase. - #321
Merged
gcf-merge-on-green[bot] merged 5 commits intoMay 23, 2023
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
jakehilton
force-pushed
the
fix-reserver-check
branch
from
May 16, 2023 18:00
6253520 to
b03c69b
Compare
skuma0404
approved these changes
May 16, 2023
Contributor
|
@jakehilton, can you please run nox -s blacken once before committing and look at the tests failing |
Contributor
Author
|
@asthamohta I fixed up the errors being reported. There were a few tests failing locally before my changes and I confirmed no new errors were generated. Can we re-run the tests again to see if something pops? Thanks! |
asthamohta
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319