This repository was archived by the owner on Mar 9, 2026. It is now read-only.
docs: fix get topic_path in subscriber sample - #210
Merged
plamut merged 2 commits intoSep 28, 2020
Conversation
marjohkan
reviewed
Sep 25, 2020
marjohkan
left a comment
There was a problem hiding this comment.
Are you meaning to create an instance of pubsub.SubscriberClient and name the variable "publisher"?
Line 40:
# publisher = pubsub.SubscriberClient()
ryanyuan
force-pushed
the
fix/subscriber-get-topic-path-docs
branch
from
September 25, 2020 22:57
e2877a5 to
7e45f19
Compare
Contributor
Author
|
@marjohkan It should be 'publisher = pubsub.PublisherClient()'. My bad, copy/paste error. |
…into fix/subscriber-get-topic-path-docs
Contributor
Author
|
@plamut I just accidentally removed googleapis/api-pubsub from reviewers. |
plamut
approved these changes
Sep 28, 2020
plamut
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for catching and fixing this!
Contributor
|
"Stream removed" flakiness caused the Python3.7 samples check to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #209 🦕