tests: fix failing e2e tests - #726
Conversation
| @@ -1432,9 +1433,7 @@ def square_num(x): | |||
|
|
|||
|
|
|||
| def test_remote_function_via_session_vpc_invalid(session): | |||
There was a problem hiding this comment.
TODO: Might be better to replace this test with a unit test where we verify that we're actually sending VPC info in the relevant requests.
There was a problem hiding this comment.
Removed this test, as it's redundant with the check here: https://github.com/googleapis/python-bigquery-dataframes/blob/72e95834f8755760f3529d38f340703f3b971f0a/tests/system/large/test_remote_function.py#L1426
We already check the VPC is added to the Cloud Function metadata here: https://github.com/googleapis/python-bigquery-dataframes/blob/72e95834f8755760f3529d38f340703f3b971f0a/tests/system/large/test_remote_function.py#L1426
|
Filed internal issue 343447415 to investigate. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕