Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rootkiller6788/firebase__firebase-admin-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cbacb02
Choose a base ref
...
head repository: firebase/firebase-admin-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: de45607
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 23, 2026

  1. feat(fcm): Migrate topic management to FCM v1 API (firebase#980)

    * feat(fcm): Migrate topic management to FCM v1 API
    
    * fix(fcm): Prevent headers mutation race condition and deduplicate topic error parsing
    
    - Pass a copy of self._fcm_headers in topic management requests to prevent concurrent mutation race conditions in ThreadPoolExecutor.
    - Extract common error parsing logic from _build_topic_subscription_result_from_requests_error and _build_topic_subscription_result_from_httpx_error into _build_topic_subscription_result.
    
    * fix(fcm): Improve topic management performance and fix test lint issues
    
    - Hoist URL-encoded topic computation out of the per-token request loops.
    - Mount an HTTPAdapter with a connection pool size of 100 on the FCM client session.
    - Fix line length and method signature override lint warnings in test_messaging.py.
    
    * fix(fcm): Addressed review improvements for FCM v1 topic management
    
    - Added type annotations to public topic management functions and internal methods
    - Updated HTTP status code mapping (401->UNAUTHENTICATED, 503->UNAVAILABLE, 408/504->DEADLINE_EXCEEDED) and prioritized status codes over free-form message strings
    - Updated topic regex with \Z to reject trailing newlines
    - Passed header copies in send, send_each, and send_each_async to prevent concurrency mutations
    - Added test coverage for status code mapping, async argument validation, prefixed topics, and async batch unsubscribe
    
    * chore(fcm): Trigger CI workflows
    lahirumaramba authored Sep 23, 2026
    Configuration menu
    Copy the full SHA
    46edf94 View commit details
    Browse the repository at this point in the history
  2. fix(appcheck): Use v1beta endpoint for verifyAppCheckToken (firebase#987

    )
    
    * fix(fac): Use v1beta endpoint for verifyAppCheckToken
    
    Updated _AppCheckService._VERIFY_URL_FORMAT to point to the v1beta endpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) for replay protection verification.
    
    * chore(fac): Fix line length lint in test_app_check.py
    lahirumaramba authored Sep 23, 2026
    Configuration menu
    Copy the full SHA
    6d5d8b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de45607 View commit details
    Browse the repository at this point in the history
Loading