-
Notifications
You must be signed in to change notification settings - Fork 154
Comparing changes
Open a pull request
base repository: chadly/Geocoding.net
base: master
head repository: exceptionless/Geocoding.net
compare: main
- 16 commits
- 187 files changed
- 3 contributors
Commits on Mar 20, 2026
-
Update AGENTS.md for Geocoding.net
Replace Exceptionless-specific content with accurate Geocoding.net project details including repository overview, project structure, coding standards, testing guidance, and available skills/agents.
Configuration menu - View commit details
-
Copy full SHA for c9e8778 - Browse repository at this point
Copy the full SHA c9e8778View commit details -
Add Geocoding.slnx and Directory.Build.props, xunit v3
- Add modern XML solution file (Geocoding.slnx) - Add Directory.Build.props with shared package metadata Fix CI package feed org references - GitHub Packages: chadly → exceptionless - Feedz: foundatio/foundatio → exceptionless/geocoding
Configuration menu - View commit details
-
Copy full SHA for 8f1dc99 - Browse repository at this point
Copy the full SHA 8f1dc99View commit details -
Modernize provider projects and test infrastructure
Adopt shared SDK build settings, update provider and test package references, and bring the library code into compliance with the stricter analyzer and XML documentation requirements. The earlier build churn was driven by stale intermediates plus missing documentation and async/test-platform cleanup in the SDK-style projects, so this commit makes the provider libraries and test suite build and run cleanly under the current toolchain.
Configuration menu - View commit details
-
Copy full SHA for 9b56ff0 - Browse repository at this point
Copy the full SHA 9b56ff0View commit details -
Replace the legacy example site with a minimal API sample
Retire the old MVC example project in favor of an SDK-style ASP.NET Core sample that matches the modernized solution layout and tooling. The new sample keeps provider discovery explicit, validates reverse-geocode input up front, and returns handled problem responses when a provider is unavailable or rejects a request so the out-of-box experience is diagnosable instead of failing with unhandled exceptions.
Configuration menu - View commit details
-
Copy full SHA for c43ca26 - Browse repository at this point
Copy the full SHA c43ca26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9901603 - Browse repository at this point
Copy the full SHA 9901603View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dae38a - Browse repository at this point
Copy the full SHA 3dae38aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80b70fc - Browse repository at this point
Copy the full SHA 80b70fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8bdaa0 - Browse repository at this point
Copy the full SHA d8bdaa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 461a06f - Browse repository at this point
Copy the full SHA 461a06fView commit details -
[BREAKING]: Update target framework to netstandard2.0
Consolidates targets from netstandard1.3 and net46 to netstandard2.0 and removes redundant package references and conditional item groups. Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details.
Configuration menu - View commit details
-
Copy full SHA for c62e0f0 - Browse repository at this point
Copy the full SHA c62e0f0View commit details
Commits on Mar 23, 2026
-
Modernize providers and test infrastructure (#2)
* Modernize Geocoding.Core: pattern matching, String.* convention, nameof(), TolerantStringEnumConverter - Replace == null/!= null with is null/is not null throughout - Use uppercase String.IsNullOrWhiteSpace/String.Empty convention - Use nameof() for argument validation parameter names - Add TolerantStringEnumConverter for resilient JSON deserialization * Modernize Geocoding.Google: code style, enum completeness, sensor removal - Replace == null/!= null with is null/is not null - Use uppercase String.* convention and nameof() for validation - Add missing GoogleAddressType values (AdminLevel4-7, PlusCode, Landmark, etc.) - Add Route and Locality to GoogleComponentFilterType - Add OverDailyLimit and UnknownError to GoogleStatus - Remove obsolete sensor=false parameter from API URLs * Add Azure Maps provider and modernize Geocoding.Microsoft - Add AzureMapsGeocoder with search/reverse geocoding, culture, bounds bias - Add AzureMapsAddress with EntityType, ConfidenceLevel, neighborhood support - Fix Bing EntityType parsing: use TryParse with Unknown fallback (crash fix) - Add Unknown value to EntityType enum at position 0 - Replace == null/!= null with is null/is not null - Use uppercase String.* convention and nameof() for validation * Modernize Geocoding.Here: migrate to API-key auth, v7 endpoint, code style - Migrate from legacy AppId/AppCode to API key authentication - Update to HERE Geocoding v1 (v7) REST endpoints - Replace custom Json.cs with Newtonsoft.Json deserialization - Remove legacy two-parameter constructor (throws NotSupportedException) - Replace == null/!= null with is null/is not null - Use uppercase String.* convention and nameof() for validation - Document HereLocationType legacy v6.2 values in XML remarks * Modernize Geocoding.MapQuest: disable OSM, TolerantStringEnumConverter, code style - Disable OpenStreetMap mode (throws NotSupportedException) - Add TolerantStringEnumConverter for resilient Quality/SideOfStreet parsing - Replace == null/!= null with is null/is not null - Use uppercase String.* convention and nameof() for validation - Fix DataFormat.json value for correct API requests * Modernize Geocoding.Yahoo: code style, deprecation cleanup - Replace == null/!= null with is null/is not null - Use uppercase String.* convention and nameof() for validation - Mark as deprecated but keep functional for contributors with credentials * Modernize test suite: three-part naming, AAA pattern, credential gating - Rename all test methods to Method_Scenario_ExpectedResult format - Add Arrange/Act/Assert comments to multi-phase tests - Add Azure Maps test coverage (AzureMapsAsyncTest) - Add ProviderCompatibilityTest for cross-provider validation - Fix Yahoo tests: remove hardcoded Skip, use credential gating via SettingsFixture - Add yahooConsumerKey/yahooConsumerSecret to settings template - Use uppercase String.* convention in test infrastructure * Update README, samples, and config for provider modernization - Update README with Azure Maps provider, HERE API key migration notes - Mark Yahoo as deprecated in documentation - Update Example.Web sample with Azure Maps and modern patterns - Add docs/plan.md to .gitignore to prevent leaking internal planning docs - Update VS Code settings for workspace * Enable nullable reference types globally Add <Nullable>enable</Nullable> to Directory.Build.props so all projects enforce nullable analysis. Include a NullableAttributes.cs polyfill for NotNullWhenAttribute on netstandard2.0 where System.Diagnostics.CodeAnalysis is not available. * Migrate Geocoding.Core to System.Text.Json and annotate nullable types Replace Newtonsoft.Json with System.Text.Json across the Core library: - Replace JsonConvert with JsonSerializer in Extensions.cs - Extract TolerantStringEnumConverter as a JsonConverterFactory for STJ - Create frozen, shared JsonSerializerOptions with MakeReadOnly() - Add System.Text.Json NuGet dependency - Annotate all public types with nullable reference type annotations - Add [NotNullWhen(false)] to IsNullOrEmpty<T> extension - Add protected parameterless constructors to Address and ParsedAddress for STJ deserialization support * Migrate Google provider to System.Text.Json with nullable annotations Replace Newtonsoft.Json attributes with System.Text.Json equivalents and annotate all types with nullable reference type annotations. * Modernize Microsoft provider: STJ migration, decouple Azure Maps, fix exception handling - Replace DataContractJsonSerializer with System.Text.Json - Remove dead Bing Maps Routing API types (Route, RouteLeg, RoutePath, Shape, Warning, etc.) that were never used by the geocoding library - Type ResourceSet.Resources directly as Location[] instead of Resource[] - Decouple AzureMapsAddress from BingAddress with its own backing fields - Apply 'when' exception filters to prevent double-wrapping exceptions that are already typed as BingGeocodingException - Add null guards in ParseResponse for missing Point/Address data - Annotate all types with nullable reference type annotations - Remove Newtonsoft.Json dependency from csproj * Modernize HERE provider: STJ migration, exception filters, nullable annotations - Replace Newtonsoft.Json with System.Text.Json for API response parsing - Apply 'when' exception filters to prevent double-wrapping HereGeocodingException - Remove Newtonsoft.Json dependency from csproj - Annotate all types with nullable reference type annotations * Modernize MapQuest provider: STJ migration, constructor fix, nullable annotations - Replace Newtonsoft.Json with System.Text.Json across all MapQuest types - Add protected [JsonConstructor] parameterless constructor to MapQuestLocation to resolve STJ parameter binding conflict between FormattedAddress property (mapped to 'location' in JSON) and the constructor parameter - Fix FormattedAddress setter to silently ignore null/blank values during deserialization instead of throwing - Improve ToString() to handle empty base FormattedAddress - Annotate all types with nullable reference type annotations * Mark Yahoo provider as obsolete with nullable annotations Yahoo BOSS Geo Services has been discontinued. Mark all public types with [Obsolete] attributes directing users to alternative providers. Add NoWarn for CS0618 in csproj to suppress internal obsolete usage. Annotate types with nullable reference type annotations. * Modernize test project: AAA comments, nullable fixes, env var config - Add Arrange/Act/Assert section comments to all test methods - Fix nullable warnings with null! for test field initialization - Make theory parameters nullable where InlineData passes null - Add ! operator for reflection-based code in ProviderCompatibilityTest - Modernize SettingsFixture to read API keys from environment variables with GEOCODING_ prefix via AddEnvironmentVariables - Add xunit.v3.assert.source package for xUnit v3 compatibility - Restore regression test comment on MapQuest neighborhood test * Apply review feedback: consistent exception filters, defensive null handling - Align Google provider to use 'when' exception filter pattern consistent with Bing, Azure Maps, and HERE providers - Replace null-forgiving operator with defensive Array.Empty fallback in MapQuest Execute method * Handle disabled Google Geocoding API keys gracefully in tests Google integration failures were caused by the configured Google Cloud project having the Geocoding API disabled, which surfaced as REQUEST_DENIED and burned through the Google test matrix. Preserve Google's provider error message in GoogleGeocodingException, add a one-time cached Google availability guard that skips Google integration tests after the first denied request, and add non-network tests that lock down the parser-to-exception behavior. * Simplify Google exception tests Drop the reflection-based parser test and keep the direct exception coverage. The Google RCA is already proven by the live targeted integration check, so the extra private-method test added complexity without enough value. * Stabilize Google postal code filter coverage With the enabled Google key, the remaining Google failure was not a provider error but a ZERO_RESULTS response for the live Rothwell + NN14 component-filter query. Replace that brittle integration case with a deterministic ServiceUrl test that still verifies postal_code component filter construction without depending on drifting Google geocoder data. * Align test settings with sample provider configuration The test fixture was still reading legacy flat keys while the sample app binds a Providers section. Teach SettingsFixture to prefer Providers:*:ApiKey values and fall back to the legacy flat keys so local overrides keep working while test and sample configuration stay consistent. * Restore strict shared assertions and stable Google filter coverage The audit found two test-integrity regressions on this branch: shared White House assertions had been weakened, and the Google postal-code filter coverage was reduced to a URL-construction check. Restore the stricter shared assertions and reinstate live postal-code filter coverage with a stable Google case that returns OK today. * Restore explicit Yahoo test skipping for deprecated provider The branch docs and README say Yahoo remains deprecated and unverified, but the test suite had been re-enabled by deleting the old skip wrappers. Restore an explicit centralized skip in YahooGeocoderTest so the branch behavior matches the documented provider status and upstream OAuth issue history. * Tighten branch test integrity after full audit The full test audit found remaining expectation drift and a few integrity regressions in the branch. Align the async base White House query with the sync base, restore strict shared assertions, update Google live expectations to match current provider responses, keep Yahoo explicitly skipped while deprecated, and scope obsolete warning suppression to the Yahoo compatibility test only. * Require U.S. country signal in Google bounds-bias test The bounds-bias test still needed to tolerate ZIP-code drift, but it should not lose the country-level assertion. Keep the stable locality substring check and explicitly require the U.S. country signal in both the formatted address and the parsed address components. * Keep provider compatibility tests in provider suites Root cause: the shared test bases eagerly created live geocoder instances in their constructors, which pushed cheap constructor checks into separate files and made the test layout drift away from provider-specific suites. Switching the base tests to lazy generic geocoder access keeps those checks colocated without extra wrapper classes or reflection hacks. * Align Yahoo test configuration with provider settings Root cause: Yahoo credentials and behavior had drifted away from the shared provider-configuration pattern, which left tests, sample config, and README guidance out of sync. This restores Yahoo credential gating in tests under Providers:Yahoo while keeping the sample app clear that Yahoo stays out of the runnable surface because the legacy provider still uses insecure endpoints. * Fix provider review regressions in JSON and input handling Root cause: the review-driven cleanup exposed missing validation and compatibility gaps in provider payload handling, and one CodeQL cleanup accidentally removed null-tolerant filtering for malformed MapQuest responses. * Align project agents with Geocoding.net workflows Root cause: the repo's custom agents and owned skills were copied from Exceptionless-specific workflows and still referenced invalid skills, paths, secret storage, and handoff semantics for this codebase. * Harden Microsoft parser edge cases Malformed provider payloads and non-int enum values were still able to slip through shared deserialization paths, which could throw or allocate more than necessary during Bing and Azure response parsing. * Restore provider compatibility surfaces The remaining review feedback traced back to public compatibility breaks and stale repo wiring around legacy provider paths. This restores HERE legacy credential support, hardens provider request construction, preserves Google enum values, and realigns docs/tests/sample config with the supported compatibility surface. * Remove HERE legacy credential flow Root cause: the branch briefly restored the retired HERE app_id/app_code path even though this major-version line is meant to standardize on the current API-key-based Geocoding and Search API. Remove the legacy HERE constructor, parsing models, sample/test config, and docs so the public surface matches the intended breaking-change direction. * Tidy remaining sample and parser review feedback Root cause: a few low-risk review comments remained open after the provider cleanup even though the behavior-preserving fixes were straightforward. Alphabetize the sample provider switch and make the Core/Bing filtering logic explicit so the outstanding review feedback matches the current implementation. * Preserve Microsoft enum compatibility Root cause: adding fallback enum members and parser hardening without locking the public numeric surface left compatibility and review gaps in the Microsoft provider package. Restore stable EntityType numeric values, make Azure result filtering explicit, and add a regression snapshot so future enum drift is caught in tests. * Polish Azure parser filtering Root cause: the last Azure Maps parser cleanup still left one code-quality complaint on the reverse-address mapping loop. Use a Select-based reverse-address pipeline so the parser stays explicit about filtering and mapping without changing behavior. * Re-enable Yahoo tests behind credential gating Root cause: the Yahoo suite had been hard-skipped even when a user supplied credentials, which prevented intentional compatibility runs. Remove the unconditional Skip attributes so the existing settings gate controls whether the Yahoo tests execute. * Harden provider transport error handling Root cause: the HttpClient transport cleanup left several provider failure paths under-tested and changed exception diagnostics/contracts in ways that made regressions easier to miss. * Align Google and Yahoo transport failures Root cause: sibling providers still used the pre-hardening HTTP failure path, so status handling and bounded diagnostics were inconsistent after the transport cleanup. * Tighten transport regression coverage Root cause: the new transport hardening tests still had analyzer noise and one locale-sensitive Google channel edge case without regression coverage. * Fix Location hash stability Root cause: Location.GetHashCode accidentally combined latitude with itself, so longitude never influenced the hash for this public value-like core type. * Clean up final analyzer findings Root cause: the latest push triggered one more static-analysis pass that flagged a disposable test-helper pattern, two Yahoo immutability nits, one unreachable Yahoo throw, and avoidable empty-array allocations in MapQuest. * Close remaining final-review gaps Root cause: the provider-modernization branch still had a small set of follow-up inconsistencies around nullable annotations, Bing response handling, and the shared HttpClient test helper after the larger transport and serializer refactors. * Split shared helpers by concern Root cause: the monolithic Extensions type mixed collection, enumerable, and JSON behavior in one file, which made the API surface harder to navigate and blocked a cleaner namespace layout for the shared helpers. * Move shared helpers into Geocoding.Extensions Root cause: the first split kept a compatibility shim and legacy JSON method casing, which preserved old entry points but did not match the requested .Extensions namespace layout or the desired .NET-style naming for JSON helpers. * Use the new helpers as real extension methods Root cause: the previous revision kept the split helper classes but still invoked them like static utilities, which did not match the requested extension-method style or the naming implied by the new Geocoding.Extensions surface. * Build a real docs site and align sample/test surfaces Root cause: the repo still exposed thin ad hoc documentation, public testing docs, and sample/test structure that had drifted from the current provider model and lacked dedicated docs validation.\n\nThis adds a VitePress docs site with provider playbooks, moves plan material out of docs, adds dedicated docs CI, aligns shared test namespaces/helpers with folder structure, and makes the sample advertise only providers that are actually usable under its configuration contract. * Stabilize provider parsing and request handling Root cause: several provider code paths still relied on culture-sensitive protocol normalization and ambiguous deserialization or disposal patterns, which left review threads open and behavior dependent on locale/runtime details. * Tighten test naming and remove request disposal ownership * Apply suggestion from @niemyjski * Address remaining PR test feedback Root cause: recent test refactors introduced assertion/name mismatches and test-guard synchronization risks that triggered new review threads. * Harden MapQuest exception handling Root cause: MapQuest transport errors still exposed key-bearing request URLs in exception context and used raw Exception instead of provider-specific exceptions. * Switch Yahoo endpoints to HTTPS Root cause: Yahoo constants and test expectations still allowed plaintext HTTP URLs, which left an insecure transport path in the compatibility provider. * Restore strict Google bias and postal assertions Root cause: test modernization simplified two Google assertions and removed important location-specific expectations used to guard regression behavior. * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/guide/sample-app.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cd511b1 - Browse repository at this point
Copy the full SHA cd511b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbbf86f - Browse repository at this point
Copy the full SHA bbbf86fView commit details
Commits on Apr 21, 2026
-
Bump vite from 7.3.1 to 7.3.2 in /docs (#4)
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.1 to 7.3.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.3.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 46ed297 - Browse repository at this point
Copy the full SHA 46ed297View commit details -
Bump picomatch from 4.0.3 to 4.0.4 in /docs (#3)
Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@4.0.3...4.0.4) --- updated-dependencies: - dependency-name: picomatch dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a84c6b7 - Browse repository at this point
Copy the full SHA a84c6b7View commit details -
Enhance NuGet package publishing logic for Geocoding.Yahoo and clean …
…up documentation
Configuration menu - View commit details
-
Copy full SHA for 4142044 - Browse repository at this point
Copy the full SHA 4142044View commit details
Commits on May 5, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 8f83256 - Browse repository at this point
Copy the full SHA 8f83256View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...main